Bug 242873 (min12xxw-review)

Summary:	Review Request: min12xxw - Print filter for Minolta printer
Product:	[Fedora] Fedora	Reporter:	Lubomir Kundrak <lkundrak>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	twaugh
Target Milestone:	---	Keywords:	HardwareEnablement
Target Release:	---	Flags:	j: fedora-review+ kevin: fedora-cvs+
Hardware:	All
OS:	Linux
URL:	http://people.redhat.com/lkundrak/SPECS/min12xxw.spec
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-06-07 22:41:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	242872

Description Lubomir Kundrak 2007-06-06 06:16:57 UTC

Spec URL: http://people.redhat.com/lkundrak/SPECS/min12xxw.spec
SRPM URL: http://people.redhat.com/lkundrak/SRPMS/min12xxw-0.0.9-1.src.rpm
Description: This is a printer driver for Minolta printers.

It basically takes raw PBM input and adds Minolta protocol metadata.
The protocol is documented in format.txt that is included in %doc of this
package.

The upstream states that the code is in the beta stage, but as no known issues
are known with PagePro 1200 1300 and 1400 I mean he only means that it
is not feature complete and he wants to extends hardware compatibility to
other printers using similar protocol (e.g. TallyGenicom 9316). So this is
basically enough for drivers we ship that need this util.

This filter is actually attempted by a number of foomatic drivers actually
includes this distribution, so they are all broken at the time. Including this
tool would solve bug #242872.

Comment 1 Jason Tibbitts 2007-06-06 20:13:29 UTC

* source files match upstream:
   c32de0293c27335e99114076fe8237aa6c98b05a0fc3d4e7bc8dc594915fe100  
   min12xxw-0.0.9.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane.
* %check is not present; no test suite upstream.  I do not have the hardware 
  required to test this pacakge.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.  (Actually the 
   GPL is larger than the executables, but the entire package is only 64K.)
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

Comment 2 Lubomir Kundrak 2007-06-07 11:44:09 UTC

New Package CVS Request
=======================
Package Name: min12xxw
Short Description: Print filter for Minolta printer
Owners: lkundrak
Branches: FC-6 F-7
InitialCC: lkundrak

Comment 3 Kevin Fenzi 2007-06-07 19:50:32 UTC

No need to add yourself to CC, owners get all emails already. 
cvs done.