Bug 2429708

FTBFS due to GCC defaulting to C++20:

ogre-1.9.0/OgreMain/include/OgreMemorySTLAllocator.h:126:56: error: ‘const_pointer’ in ‘class std::allocator<void>’ does not name a type [-Wtemplate-body]

Since C++11 that should be std::allocator_traits<std::allocator<void>>::const_pointer, although since it's using std::allocator<void> the code is just dumb. Just use const void* instead of complicating things by getting the type from the allocator.

Ah this code was removed upstream more than 8 years ago:
https://github.com/OGRECave/ogre/commit/42a45d8da445df5d5c8032cbc74efb0e9644ce35

So there's no point reporting it upstream.


I can't fix this myself because the package is currently unusable in rawhide, it needs to be fixed to even use it with fedpkg:

$ fedpkg prep
error: %patchN is obsolete, use %patch N (or %patch -P N): %patch0 -p1 -b .rpath


Parsing specfile for used sources failed. Falling back to downloading all sources.
Not downloading already downloaded ogre-1.9.0-clean.tar.bz2


error: %patchN is obsolete, use %patch N (or %patch -P N): %patch0 -p1 -b .rpath

Hint: the previous command didn't check dependencies. This can be enabled by adding argument '--check-deps'
Could not execute prep: Failed to execute command.


Something like this is needed:

--- ogre-1.9.0/OgreMain/include/OgreMemorySTLAllocator.h~       2013-12-01 17:28:12.000000000 +0000
+++ ogre-1.9.0/OgreMain/include/OgreMemorySTLAllocator.h        2026-01-15 13:17:10.082899440 +0000
@@ -123,7 +123,7 @@
 
                /// memory allocation (elements, used by STL)
                inline pointer allocate( size_type count,
-                       typename std::allocator<void>::const_pointer ptr = 0 )
+                       const void ptr = 0 )
                {
                         (void)ptr;
                        // convert request to bytes

(In reply to Jonathan Wakely from comment #2)
> +                       const void ptr = 0 )

Oops, const void* obviously, not const void

(In reply to Jonathan Wakely from comment #2)
> I can't fix this myself because the package is currently unusable in
> rawhide, it needs to be fixed to even use it with fedpkg:

Pilot error. I'll apply the patch now and try a build ...

https://bodhi.fedoraproject.org/updates/FEDORA-2026-ba8e3fcf2e