Bug 2429727

FTBFS in rawhide:
SuperCollider-3.13.0-Source/external_libraries/nova-tt/nova-tt/spin_lock.hpp:101:12: error: ‘uint8_t’ in namespace ‘boost’ does not name a type

I don't know why the code uses boost::uint8_t when uint8_t has been standard for many years.

I tried to fix it, but I can't even extract the source tree for this package:

$ fedpkg prep
error: %patchN is obsolete, use %patch N (or %patch -P N): %patch0 -p1 -b .sndfile110


Parsing specfile for used sources failed. Falling back to downloading all sources.
Downloading SuperCollider-3.12.2-Source.tar.bz2 from https://src.fedoraproject.org/repo/pkgs
######################################################################## 100.0%


error: %patchN is obsolete, use %patch N (or %patch -P N): %patch0 -p1 -b .sndfile110

Hint: the previous command didn't check dependencies. This can be enabled by adding argument '--check-deps'
Could not execute prep: Failed to execute command.
$ fedpkg verrel
error: %patchN is obsolete, use %patch N (or %patch -P N): %patch0 -p1 -b .sndfile110

error: query of specfile /home/jwakely/src/fedora-scm/supercollider/supercollider.spec failed, can't parse

Could not execute verrel: Could not get n-v-r-e from /home/jwakely/src/fedora-scm/supercollider/supercollider.spec

Something like this:

--- SuperCollider-3.12.2-Source/external_libraries/nova-tt/nova-tt/spin_lock.hpp~       2022-01-09 02:11:15.000000000 +0000
+++ SuperCollider-3.12.2-Source/external_libraries/nova-tt/nova-tt/spin_lock.hpp        2026-01-15 11:38:08.775318988 +0000
@@ -22,6 +22,7 @@
 #define NOVA_TT_SPIN_LOCK_HPP
 
 #include <cassert>
+#include <cstdlib>
 
 #include <boost/atomic.hpp>
 
@@ -98,7 +99,7 @@
     public spin_lock
 {
     static const int padding_bytes = 64 - sizeof(spin_lock);
-    boost::uint8_t padding[padding_bytes];
+    std::uint8_t padding[padding_bytes];
 };
 
 } /* namespace nova */

(In reply to Jonathan Wakely from comment #2)
> Something like this:
> 
> ---
> SuperCollider-3.12.2-Source/external_libraries/nova-tt/nova-tt/spin_lock.
> hpp~       2022-01-09 02:11:15.000000000 +0000
> +++
> SuperCollider-3.12.2-Source/external_libraries/nova-tt/nova-tt/spin_lock.hpp
> 2026-01-15 11:38:08.775318988 +0000
> @@ -22,6 +22,7 @@
>  #define NOVA_TT_SPIN_LOCK_HPP
>  
>  #include <cassert>
> +#include <cstdlib>

Oops, that should be <cstdint>


>  
>  #include <boost/atomic.hpp>
>  
> @@ -98,7 +99,7 @@
>      public spin_lock
>  {
>      static const int padding_bytes = 64 - sizeof(spin_lock);
> -    boost::uint8_t padding[padding_bytes];
> +    std::uint8_t padding[padding_bytes];
>  };
>  
>  } /* namespace nova */

(In reply to Jonathan Wakely from comment #1)
> I tried to fix it, but I can't even extract the source tree for this package:

I'm an idiot, I need to git pull before I try using fedpkg.

There's an upstream change for the Asio changes in Boost 1.87.0 but it's quite invasive and applies to a much newer release than we have in Fedora:
https://github.com/supercollider/supercollider/pull/6576

Actually not *that* much newer, they just make upstream releases quite often.

That also needs this follow-up:
https://github.com/supercollider/supercollider/pull/6590

It would certainly be easier to just update rawhide to a current release, which already has these changes.

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Hello,

Please note that this comment was generated automatically by https://forge.fedoraproject.org/releng/tooling/src/branch/main/release-process/bug-filing/follow-policy/follow_policy.py
If you feel that this output has mistakes, please open an issue at https://forge.fedoraproject.org/releng/tickets/issues

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Here is a scratch build for the latest release: https://koji.fedoraproject.org/koji/taskinfo?taskID=142734389 . If that goes well I'll fedpkg push.
Thank you for the report, sorry for the delay!

Alas, the project now uses git submodules... Now trying to figure-out how to package them.

Ok, the submodules are actually included in the source tarball, it's their paths that changed in the last release. Here is a successful scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=142739705 and I pushed the fix to the distgit.

Tristan, due to the process, this package was orphaned right now as this was never built and fixed.

You might want to claim the package and actually build it to fix this.

This package has been orphaned.

You can pick it up at https://src.fedoraproject.org/rpms/supercollider by clicking button "Take". If nobody picks it up, it will be retired and removed from a distribution.

This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Automation has figured out the package is retired in rawhide.

If you like it to be unretired, please open a ticket at https://forge.fedoraproject.org/releng/tickets/issues/new?template=.forgejo%2fISSUE_TEMPLATE%2funretire-package.md