Bug 243010
| Summary: | Review Request: perl-Compress-Raw-Bzip2 - Perl interface to bzip2 compression library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robin Norwood <robin.norwood> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mmaslano |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-07 21:36:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robin Norwood
2007-06-06 21:47:46 UTC
There are 5 compression-related packages needed for a new Compress::Zlib (2.004), including this one. Here are the bugzilla URLs for them: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228537 - perl-IO-Compress-Base https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243010 - perl-Compress-Raw-Bzip2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243012 - perl-Compress-Raw-Zlib https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243016 - perl-IO-Compress-Bzip2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243019 - perl-IO-Compress-Zlib This builds fine for me, but it looks like test coverage could be enhanced by a
build dependency on perl(Test::Pod):
t/99pod........skipped
all skipped: Test::Pod 1.00 required for testing POD
Since that's a trivial fix and it's the only issue I see with this package, I'll
go ahead and approve it and you can fix it when you check in.
Review:
* source files match upstream:
5711ea0627018fdf94eba9443c6e0c7fe109c396ef6896716f3a151eed6225ad
Compress-Raw-Bzip2-2.004.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
X BuildRequires missing Test::Pod
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
Bzip2.so()(64bit)
perl(Compress::Raw::Bunzip2)
perl(Compress::Raw::Bzip2)
perl-Compress-Raw-Bzip2 = 2.004-1.fc8
=
perl >= 0:5.004
perl(:MODULE_COMPAT_5.8.8)
perl(AutoLoader)
perl(Carp)
perl(Exporter)
perl(bytes)
perl(constant)
perl(strict)
perl(warnings)
X %check is present, but one test is skipped due to missing dependencies.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
APPROVED
Alrightey, then: new spec and SRPM: Spec URL: http://people.redhat.com/rnorwood/rpms/Compression/perl-Compress-Raw-Bzip2.spec SRPM URL: http://people.redhat.com/rnorwood/rpms/Compression/perl-Compress-Raw-Bzip2-2.004-1.src.rpm with Test::Pod coverage goodness. New Package CVS Request ======================= Package Name: perl-Compress-Raw-Bzip2 Short Description: Perl interface to bzip2 compression library Owners: rnorwood Branches: devel InitialCC: fedora-perl-devel-list cvs done. package imported and built. *** Bug 573928 has been marked as a duplicate of this bug. *** |