Bug 2430668

Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Taking this review.

It seems the bot can't figure out how to deal with your URLs. FYI, as a packager, you have access to your own fedorapeople.org space. And alternatively, you can also use COPR as well to "host" something that the bots can read.

Initial spec review

> Source0:        https://github.com/hoshinolina/obs-pwvideo/archive/%{version_no_tilde}/obs-pwvideo-%{version_no_tilde}.tar.gz

This can be simplified to "%{url}/archive/%{version_no_tilde}/obs-pwvideo-%{version_no_tilde}.tar.gz"

> %setup -q -n obs-pwvideo-%{version_no_tilde}

Please use "%autosetup" in place of "%setup -q". 

But also as a further optimization, you can use the relatively new "%autosetup -C" instead of "%autosetup -n obs-pwvideo-%{version_no_tilde}" as long as you don't intend to backport it to RHEL via EPEL.

(there's an open backport request for EPEL 10, but at the moment, it is not yet available)

> %build
> %cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
>        -GNinja
>
> %cmake_build

Please split this out into a %conf stage unless you intend to backport this to EPEL 9. Such a split looks like this:

%conf
%cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
       -GNinja

%build
%cmake_build

Updated spec and SRPM here! Sorry about the nextcloud thing, I was trying to access the wrong server and I was wondering why it didn't work, that's why I ended up using nextcloud...

Spec URL: https://hoshinolina.fedorapeople.org/obs-studio-plugin-pwvideo.spec
SRPM URL: https://hoshinolina.fedorapeople.org/obs-studio-plugin-pwvideo-0.1.0~rc2-1.fc43.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10042232
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430668-obs-studio-plugin-pwvideo/fedora-rawhide-x86_64/10042232-obs-studio-plugin-pwvideo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Fixed the LICENSE thing that the review template pointed out in the upstream repo (I plan to tag & bump before actually pushing this to Fedora)

Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Licensing is correct and license data installed
* No serious issues from rpmlint

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-studio-plugin-pwvideo

FEDORA-2026-10375a4327 (obs-studio-plugin-pwvideo-0.1.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-10375a4327

FEDORA-2026-10375a4327 (obs-studio-plugin-pwvideo-0.1.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2026-d463dd0320 (obs-studio-plugin-pwvideo-0.1.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-d463dd0320

FEDORA-2026-bf257e88da (obs-studio-plugin-pwvideo-0.1.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-bf257e88da

FEDORA-2026-d463dd0320 (obs-studio-plugin-pwvideo-0.1.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2026-bf257e88da (obs-studio-plugin-pwvideo-0.1.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.