Bug 2430668 - Review Request: obs-studio-plugin-pwvideo - OBS PipeWire video source
Summary: Review Request: obs-studio-plugin-pwvideo - OBS PipeWire video source
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/hoshinolina/obs-pw...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-01-18 08:44 UTC by Hoshino Lina
Modified: 2026-02-01 01:03 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-01-31 09:23:14 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Hoshino Lina 2026-01-18 08:44:02 UTC
Spec URL: https://cloud.hoshinolina.net/public.php/dav/files/PNJNK24BXzCGw8H
SRPM URL: https://cloud.hoshinolina.net/public.php/dav/files/RpAcaTi3qFjpYy4
Description:

Generic PipeWire video source for OBS.
Useful for routing arbitrary video streams into
your scenes.

Fedora Account System Username: hoshinolina

Comment 1 Fedora Review Service 2026-01-18 08:44:31 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2026-01-18 10:42:40 UTC
Taking this review.

Comment 3 Neal Gompa 2026-01-18 10:54:25 UTC
It seems the bot can't figure out how to deal with your URLs. FYI, as a packager, you have access to your own fedorapeople.org space. And alternatively, you can also use COPR as well to "host" something that the bots can read.

Initial spec review

> Source0:        https://github.com/hoshinolina/obs-pwvideo/archive/%{version_no_tilde}/obs-pwvideo-%{version_no_tilde}.tar.gz

This can be simplified to "%{url}/archive/%{version_no_tilde}/obs-pwvideo-%{version_no_tilde}.tar.gz"

> %setup -q -n obs-pwvideo-%{version_no_tilde}

Please use "%autosetup" in place of "%setup -q". 

But also as a further optimization, you can use the relatively new "%autosetup -C" instead of "%autosetup -n obs-pwvideo-%{version_no_tilde}" as long as you don't intend to backport it to RHEL via EPEL.

(there's an open backport request for EPEL 10, but at the moment, it is not yet available)

> %build
> %cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
>        -GNinja
>
> %cmake_build

Please split this out into a %conf stage unless you intend to backport this to EPEL 9. Such a split looks like this:

%conf
%cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
       -GNinja

%build
%cmake_build

Comment 4 Hoshino Lina 2026-01-21 15:47:37 UTC
Updated spec and SRPM here! Sorry about the nextcloud thing, I was trying to access the wrong server and I was wondering why it didn't work, that's why I ended up using nextcloud...

Spec URL: https://hoshinolina.fedorapeople.org/obs-studio-plugin-pwvideo.spec
SRPM URL: https://hoshinolina.fedorapeople.org/obs-studio-plugin-pwvideo-0.1.0~rc2-1.fc43.src.rpm

Comment 5 Fedora Review Service 2026-01-21 15:53:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10042232
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430668-obs-studio-plugin-pwvideo/fedora-rawhide-x86_64/10042232-obs-studio-plugin-pwvideo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Hoshino Lina 2026-01-21 16:04:39 UTC
Fixed the LICENSE thing that the review template pointed out in the upstream repo (I plan to tag & bump before actually pushing this to Fedora)

Comment 7 Neal Gompa 2026-01-21 16:27:29 UTC
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Licensing is correct and license data installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 8 Fedora Admin user for bugzilla script actions 2026-01-27 09:00:49 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-studio-plugin-pwvideo

Comment 9 Fedora Update System 2026-01-31 09:18:50 UTC
FEDORA-2026-10375a4327 (obs-studio-plugin-pwvideo-0.1.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-10375a4327

Comment 10 Fedora Update System 2026-01-31 09:23:14 UTC
FEDORA-2026-10375a4327 (obs-studio-plugin-pwvideo-0.1.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2026-01-31 10:06:12 UTC
FEDORA-2026-d463dd0320 (obs-studio-plugin-pwvideo-0.1.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-d463dd0320

Comment 12 Fedora Update System 2026-01-31 10:06:28 UTC
FEDORA-2026-bf257e88da (obs-studio-plugin-pwvideo-0.1.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-bf257e88da

Comment 13 Fedora Update System 2026-02-01 00:50:49 UTC
FEDORA-2026-d463dd0320 (obs-studio-plugin-pwvideo-0.1.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2026-02-01 01:03:05 UTC
FEDORA-2026-bf257e88da (obs-studio-plugin-pwvideo-0.1.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.