Bug 2430862
| Summary: | Review Request: facebook-time - Meta's Time libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pawel Zmarzly <pzmarzly> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | michel, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | michel:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-01-21 14:50:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Pawel Zmarzly
2026-01-19 16:15:22 UTC
Thanks Pawel! Taking this review, I can sponsor afterwards. Provides: golang-github-facebook-time-vendor-licenses = %autorelease
^ this should be
Provides: golang-github-facebook-time-vendor-licenses = %{version}-%{release}
Obsoletes: golang-github-facebook-time-vendor-licenses < 0:20260107gitdbb4529-2
^ this should be
Obsoletes: golang-github-facebook-time-vendor-licenses = < 0^20260107gitdbb4529-2
We also need to make sure this produces a release higher than 1 or it will not replace the older packages. You can do this as a one-off so we don't have to mess up the spec when importing the package, please have this in your commit message
https://fedora-infra.github.io/rpmautospec-docs/autorelease.html#one-off-bumping-release-numbers
[bump release: 2]
Updated. https://copr.fedorainfracloud.org/coprs/pawo2500/facebook-time-wip/build/10035637/ https://download.copr.fedorainfracloud.org/results/pawo2500/facebook-time-wip/srpm-builds/10035637/ Copr build: https://copr.fedorainfracloud.org/coprs/build/10036003 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430862-facebook-time/fedora-rawhide-x86_64/10036003-facebook-time/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Changes from the previous spec looks appropriate (provides/conflicts, changing the package name when they show up in the logs. LGTM - APPROVED The Pagure repository was created at https://src.fedoraproject.org/rpms/facebook-time FEDORA-2026-dce9c2c5b5 (facebook-time-0^20260107gitdbb4529-4.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-dce9c2c5b5 FEDORA-2026-dce9c2c5b5 (facebook-time-0^20260107gitdbb4529-4.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |