Bug 2430862 - Review Request: facebook-time - Meta's Time libraries
Summary: Review Request: facebook-time - Meta's Time libraries
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2026-01-19 16:15 UTC by Pawel Zmarzly
Modified: 2026-01-21 14:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-01-21 14:50:23 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Pawel Zmarzly 2026-01-19 16:15:22 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/pawo2500/facebook-time-wip/srpm-builds/10035509/facebook-time.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/pawo2500/facebook-time-wip/srpm-builds/10035509/facebook-time-020260107gitdbb4529-1.fc44.src.rpm
Description: Meta's Time libraries
Fedora Account System Username: pawo2500

COPR: https://copr.fedorainfracloud.org/coprs/pawo2500/facebook-time-wip/

This will be a rename of https://src.fedoraproject.org/rpms/golang-github-facebook-time SRPM, aligning with new Golang packaging guidelines. Binary RPMs do not change name or version, except for golang-github-facebook-time-vendor-licenses being replaced with facebook-time-vendor-licenses (with Provides and Obsoletes). Old repo will be retired.

Comment 1 Michel Lind 2026-01-19 16:20:07 UTC
Thanks Pawel! Taking this review, I can sponsor afterwards.

Comment 2 Michel Lind 2026-01-19 16:30:10 UTC
Provides:       golang-github-facebook-time-vendor-licenses = %autorelease

^ this should be
Provides:       golang-github-facebook-time-vendor-licenses = %{version}-%{release}

Obsoletes:      golang-github-facebook-time-vendor-licenses < 0:20260107gitdbb4529-2

^ this should be 
Obsoletes:      golang-github-facebook-time-vendor-licenses = < 0^20260107gitdbb4529-2

We also need to make sure this produces a release higher than 1 or it will not replace the older packages. You can do this as a one-off so we don't have to mess up the spec when importing the package, please have this in your commit message

https://fedora-infra.github.io/rpmautospec-docs/autorelease.html#one-off-bumping-release-numbers

[bump release: 2]

Comment 4 Fedora Review Service 2026-01-19 19:56:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10036003
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2430862-facebook-time/fedora-rawhide-x86_64/10036003-facebook-time/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Michel Lind 2026-01-20 15:19:29 UTC
Changes from the previous spec looks appropriate (provides/conflicts, changing the package name when they show up in the logs.

LGTM - APPROVED

Comment 6 Fedora Admin user for bugzilla script actions 2026-01-20 16:23:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/facebook-time

Comment 7 Fedora Update System 2026-01-21 14:46:07 UTC
FEDORA-2026-dce9c2c5b5 (facebook-time-0^20260107gitdbb4529-4.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-dce9c2c5b5

Comment 8 Fedora Update System 2026-01-21 14:50:23 UTC
FEDORA-2026-dce9c2c5b5 (facebook-time-0^20260107gitdbb4529-4.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.