Bug 243387
| Summary: | Package should require yelp for its help | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matěj Cepl <mcepl> |
| Component: | gnochm | Assignee: | Patrice Dumas <pertusus> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | mcepl, mcepl |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.9.10-1.fc8 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-08 19:12:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matěj Cepl
2007-06-08 16:26:07 UTC
All of these bug reports are (most likely) wrong. The package should NOT require yelp. We went through effort to ensure that yelp is not a requirement for the desktop. You should ask yourself: will the package fail to work if yelp is not installed? If not, do not require yelp. If you have already committed this fix blindly, I ask that you consider undoing it so derivative projects can continue using your package without help if they so choose. We have added yelp to the default install via comps so that all installs get yelp by default unless they specifically ask for it to be removed. We should honor that. Please undo your changes if you have made them and/or mark this bug WONTFIX. Thanks. (In reply to comment #1) > You should ask yourself: will the package fail to work if yelp is not installed? > If not, do not require yelp. Depends on what working means. Of course it is only needed for the help. When I click on the help button in the interface nothing happens if yelp isn't installed. And on the console I get, quite logically: Traceback (most recent call last): File "/usr/bin/gnochm", line 1565, in on_contents_activate gnome.help_display(path_help, 'index') gobject.GError: There was an error launching the default action command associated with this location. So it isn't plain obvious that it isn't needed. From the user perspective having help system working seems to be better to me. Seems that yelp requires only the usual gnome stuff, and firefox. So it doesn't seems to me to be really problematic to bring in yelp. Maybe it would be better for yelp not to require firefox itself, but a renderer engine, but that's not an issue for gnochm. > If you have already committed this fix blindly, I ask that you consider undoing I try to avoid doing things blindly. > it so derivative projects can continue using your package without help if they > so choose. In that case they can still remove the Requires. > We have added yelp to the default install via comps so that all installs get > yelp by default unless they specifically ask for it to be removed. We should > honor that. Please undo your changes if you have made them and/or mark this bug > WONTFIX. Thanks. comps is irrelevant, the Requires and comps don't embed the same information. In my opinion, if you want project that use yelp not to require it you should come with guideline, otherwise it should certainly be left to the packagers. |