Bug 243571

This failed to build for me:
+ /usr/bin/python setup.py install -O1 --skip-build --root
/var/tmp/python-mechanoid-0.6.9-1.fc8-root-mockbuild
running install
error: invalid Python installation: unable to open
/usr/lib64/python2.5/config/Makefile (No such file or directory)
error: Bad exit status from /var/tmp/rpm-tmp.12975 (%install)

You need a build dependency on python-devel.  Adding it gets things building.

rpmlint says:
  W: python-mechanoid wrong-file-end-of-line-encoding 
   /usr/share/doc/python-mechanoid-0.6.9/COPYING
and indeed that file seems to have come from DOS and needs fixing.

The package has a test suite, and it almost runs, but because DNS is not
configured in mock, this fails:
  socket.gethostbyname(socket.gethostname())
which makes a single test (out of 116) fail.  It may be worth patching out to
get some test coverage, but then it might become a pain because nothing stops
them from adding more network-using tests in the future.

If you don't want to add the test suite, do go ahead and add a %check section
with the line for running the tests commented out so that folks who want to run
it themselves can easily do so.

Review:
* source files match upstream:
   e6d39a80993055466be234d279f08a42fdd51896ad19e13024b54ff226b8c990  
   mechanoid-0.6.9.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X BuildRequires missing python-devel.
* %clean is present.
* package builds in mock (development, x86_64) after adding missing BR.
* package installs properly
X rpmlint has a valid complaint.
* final provides and requires are sane:
   python-mechanoid = 0.6.9-1.fc8
  =
   python(abi) = 2.5
* %check is not present; one test cannot be run in mock.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Thanks for the feedback.

I've made the changes you recommended.  I changed the test with a sed
replacement to make it work without requiring net access.  I will report these
to upstream so hopefully they are corrected in the future.

SPEC: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid.spec
SRPM: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid-0.6.9-2.fc7.src.rpm

Thanks,
Sean

I see you patched the test but you still need something to call it:

%check
%{__python} test.py

Also, you need to go the other way with the COPYING file; not unix2dos but
dos2unix.  Actually, it's easier to do it with sed:

sed -i 's/\r//' COPYING

That saves you the dos2unix dependency as well.

Good catch on the unix2dos.  I've added the above two items.

SPEC: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid.spec
SRPM: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid-0.6.9-3.fc7.src.rpm

Heh, actually you didn't bump the release for that one, which annoys rpmlint a
bit.  Also, don't forget to double '%' in your changelog.

Anyway, you've fixed any substantive complaints I have; just be sure your
version-release matches your changelog entry and fix up that percent sign when
you check in.

APPROVED

New Package CVS Request
=======================
Package Name: python-mechanoid
Short Description: Python Programmatic Web Browser
Owners: jafo
Branches: FC-6 F-7
InitialCC: jafo

CVS done.

Package Change Request
======================
Package Name: python-mechanoid
New Branches: EL-5

I forgot to request branches for EPEL in previous request.

branch done.

Please don't forget to close this ticket once the package has been imported and
built.

ping?

It appears that the source has never been imported into the cvs repository or built.

Thanks for the ping.  I've gotten it built and it's ready to go.