Bug 243571 - Review Request: python-mechanoid - Python Programmatic Web Browser
Review Request: python-mechanoid - Python Programmatic Web Browser
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
low Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-06-09 19:08 EDT by jafo-redhat
Modified: 2007-11-30 17:12 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-06-15 16:30:57 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description jafo-redhat 2007-06-09 19:08:51 EDT
Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid.spec
SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid-0.6.9-1.fc7.src.rpm
Description: mechanoid is a programmatic browser written in Python.  It is not a
web-bot and does not parse /robots.txt. It is intended to function as
the backend of special browsers, such as voice-text/text-voice browsers,
or to perform directed tasks, such as login to SourceForge to do a Quick
Release or to send and receive Yahoo! web mail.
Comment 1 Jason Tibbitts 2007-06-09 23:32:14 EDT
This failed to build for me:
+ /usr/bin/python setup.py install -O1 --skip-build --root
running install
error: invalid Python installation: unable to open
/usr/lib64/python2.5/config/Makefile (No such file or directory)
error: Bad exit status from /var/tmp/rpm-tmp.12975 (%install)

You need a build dependency on python-devel.  Adding it gets things building.

rpmlint says:
  W: python-mechanoid wrong-file-end-of-line-encoding 
and indeed that file seems to have come from DOS and needs fixing.

The package has a test suite, and it almost runs, but because DNS is not
configured in mock, this fails:
which makes a single test (out of 116) fail.  It may be worth patching out to
get some test coverage, but then it might become a pain because nothing stops
them from adding more network-using tests in the future.

If you don't want to add the test suite, do go ahead and add a %check section
with the line for running the tests commented out so that folks who want to run
it themselves can easily do so.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X BuildRequires missing python-devel.
* %clean is present.
* package builds in mock (development, x86_64) after adding missing BR.
* package installs properly
X rpmlint has a valid complaint.
* final provides and requires are sane:
   python-mechanoid = 0.6.9-1.fc8
   python(abi) = 2.5
* %check is not present; one test cannot be run in mock.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Comment 2 jafo-redhat 2007-06-10 00:12:33 EDT
Thanks for the feedback.

I've made the changes you recommended.  I changed the test with a sed
replacement to make it work without requiring net access.  I will report these
to upstream so hopefully they are corrected in the future.

SPEC: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid.spec
SRPM: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid-0.6.9-2.fc7.src.rpm

Comment 3 Jason Tibbitts 2007-06-10 00:36:37 EDT
I see you patched the test but you still need something to call it:

%{__python} test.py

Also, you need to go the other way with the COPYING file; not unix2dos but
dos2unix.  Actually, it's easier to do it with sed:

sed -i 's/\r//' COPYING

That saves you the dos2unix dependency as well.
Comment 4 jafo-redhat 2007-06-10 00:42:53 EDT
Good catch on the unix2dos.  I've added the above two items.

SPEC: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid.spec
SRPM: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-mechanoid-0.6.9-3.fc7.src.rpm
Comment 5 Jason Tibbitts 2007-06-10 00:50:39 EDT
Heh, actually you didn't bump the release for that one, which annoys rpmlint a
bit.  Also, don't forget to double '%' in your changelog.

Anyway, you've fixed any substantive complaints I have; just be sure your
version-release matches your changelog entry and fix up that percent sign when
you check in.

Comment 6 Sean Reifschneider 2007-06-10 01:24:28 EDT
New Package CVS Request
Package Name: python-mechanoid
Short Description: Python Programmatic Web Browser
Owners: jafo@tummy.com
Branches: FC-6 F-7
InitialCC: jafo@tummy.com
Comment 7 Jason Tibbitts 2007-06-10 01:26:52 EDT
CVS done.
Comment 8 Sean Reifschneider 2007-06-11 19:11:37 EDT
Package Change Request
Package Name: python-mechanoid
New Branches: EL-5

I forgot to request branches for EPEL in previous request.
Comment 9 Kevin Fenzi 2007-06-11 19:48:05 EDT
branch done.
Comment 10 Jason Tibbitts 2007-06-15 12:31:36 EDT
Please don't forget to close this ticket once the package has been imported and
Comment 11 Toshio Ernie Kuratomi 2007-10-12 21:48:00 EDT

It appears that the source has never been imported into the cvs repository or built.
Comment 12 Sean Reifschneider 2007-10-22 01:42:22 EDT
Thanks for the ping.  I've gotten it built and it's ready to go.

Note You need to log in before you can comment on or make changes to this bug.