Bug 2439318
| Summary: | Review Request: perl-Sub-HandlesVia-XS - XS parts for Sub::HandlesVia | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Michal Josef Spacek <mspacek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mspacek, package-review |
| Target Milestone: | --- | Flags: | mspacek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-03-07 00:25:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2434844 | ||
|
Description
Jitka Plesnikova
2026-02-12 13:58:06 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires:
There are "perl(File::Copy)" and "perl(File::Spec)" which are not required, this is for usage without ExtUtils::Constant.
$ rpm -qp --requires perl-Sub-HandlesVia-XS-0.003004-1.fc45.x86_64.rpm | sort | uniq -c | grep -v rpmlib
1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit)
1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit)
1 libc.so.6(GLIBC_2.14)(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.3.4)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libc.so.6(GLIBC_2.8)(64bit)
1 libc.so.6()(64bit)
1 libperl.so.5.42()(64bit)
1 perl-libs
1 perl(:MODULE_COMPAT_5.42.0)
1 perl(strict)
1 perl(Types::Common) >= 2.010001
1 perl(:VERSION) >= 5.8.8
1 perl(warnings)
1 perl(XSLoader)
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -qp --provides perl-Sub-HandlesVia-XS-0.003004-1.fc45.x86_64.rpm | sort | uniq -c
1 perl-Sub-HandlesVia-XS(x86-64) = 0.003004-1.fc45
1 perl(Sub::HandlesVia::XS) = 0.003004
1 perl-Sub-HandlesVia-XS = 0.003004-1.fc45
Binary provides are Ok.
$ rpmlint ./perl-Sub-HandlesVia-XS*
perl-Sub-HandlesVia-XS-tests.x86_64: E: no-binary
perl-Sub-HandlesVia-XS.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Sub-HandlesVia-XS/LICENSE
I think there is missine "BuildArch: noarch" to "%package tests" section.
> BuildRequires: > There are "perl(File::Copy)" and "perl(File::Spec)" which are not required, > this is for usage without ExtUtils::Constant. The modules are loaded by using 'use' and it caused that modules are imported in compile time. The module is not imported only when 'if' is used as part of 'use' function. That is not this case. > $ rpmlint ./perl-Sub-HandlesVia-XS* > perl-Sub-HandlesVia-XS-tests.x86_64: E: no-binary > perl-Sub-HandlesVia-XS.x86_64: E: incorrect-fsf-address I'll report the incorrect address to upstream. > /usr/share/licenses/perl-Sub-HandlesVia-XS/LICENSE > I think there is missine "BuildArch: noarch" to "%package tests" > section. Updated spec. Updated files on the same links. > > BuildRequires:
> > There are "perl(File::Copy)" and "perl(File::Spec)" which are not required,
> > this is for usage without ExtUtils::Constant.
> The modules are loaded by using 'use' and it caused that modules are imported in compile time.
> The module is not imported only when 'if' is used as part of 'use' function. That is not this
> case.
Ach, you are right.
Incorrect FSF address issue: https://github.com/tobyink/p5-sub-handlesvia-xs/issues/2 $ rpmlint ./perl-Sub-HandlesVia-XS* perl-Sub-HandlesVia-XS-tests.noarch: W: no-documentation perl-Sub-HandlesVia-XS.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Sub-HandlesVia-XS/LICENSE = 5 packages and 1 specfiles checked; 1 errors, 1 warnings, 21 filtered, 1 badness; has taken 0.5 s = Package looks good now. Resolution: Approved The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Sub-HandlesVia-XS FEDORA-2026-6077e64404 (perl-Sub-HandlesVia-XS-0.003004-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-6077e64404 FEDORA-2026-6077e64404 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-6077e64404` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-6077e64404 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-6077e64404 (perl-Sub-HandlesVia-XS-0.003004-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |