Bug 2439318 - Review Request: perl-Sub-HandlesVia-XS - XS parts for Sub::HandlesVia
Summary: Review Request: perl-Sub-HandlesVia-XS - XS parts for Sub::HandlesVia
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Josef Spacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2434844
TreeView+ depends on / blocked
 
Reported: 2026-02-12 13:58 UTC by Jitka Plesnikova
Modified: 2026-03-07 00:25 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-03-07 00:25:08 UTC
Type: ---
Embargoed:
mspacek: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2026-02-12 13:58:06 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Sub-HandlesVia-XS/perl-Sub-HandlesVia-XS.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Sub-HandlesVia-XS/perl-Sub-HandlesVia-XS-0.003004-1.fc45.src.rpm
Description:
Use Sub::HandlesVia. That module will make use of Sub::HandlesVia::XS
when it can. No user-serviceable parts inside.

Fedora Account System Username: jplesnik

Comment 1 Michal Josef Spacek 2026-02-19 12:52:32 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires:
There are "perl(File::Copy)" and "perl(File::Spec)" which are not required, this is for usage without ExtUtils::Constant.

$ rpm -qp --requires perl-Sub-HandlesVia-XS-0.003004-1.fc45.x86_64.rpm  | sort | uniq -c | grep -v rpmlib
      1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit)
      1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libc.so.6(GLIBC_2.8)(64bit)
      1 libc.so.6()(64bit)
      1 libperl.so.5.42()(64bit)
      1 perl-libs
      1 perl(:MODULE_COMPAT_5.42.0)
      1 perl(strict)
      1 perl(Types::Common) >= 2.010001
      1 perl(:VERSION) >= 5.8.8
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Sub-HandlesVia-XS-0.003004-1.fc45.x86_64.rpm  | sort | uniq -c
      1 perl-Sub-HandlesVia-XS(x86-64) = 0.003004-1.fc45
      1 perl(Sub::HandlesVia::XS) = 0.003004
      1 perl-Sub-HandlesVia-XS = 0.003004-1.fc45
Binary provides are Ok.

$ rpmlint ./perl-Sub-HandlesVia-XS*
perl-Sub-HandlesVia-XS-tests.x86_64: E: no-binary
perl-Sub-HandlesVia-XS.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Sub-HandlesVia-XS/LICENSE
I think there is missine "BuildArch:      noarch" to "%package tests" section.

Comment 2 Jitka Plesnikova 2026-02-19 14:59:28 UTC
> BuildRequires:
> There are "perl(File::Copy)" and "perl(File::Spec)" which are not required,
> this is for usage without ExtUtils::Constant.
The modules are loaded by using 'use' and it caused that modules are imported in compile time.
The module is not imported only when 'if' is used as part of 'use' function. That is not this
case.

> $ rpmlint ./perl-Sub-HandlesVia-XS*
> perl-Sub-HandlesVia-XS-tests.x86_64: E: no-binary
> perl-Sub-HandlesVia-XS.x86_64: E: incorrect-fsf-address
I'll report the incorrect address to upstream.

> /usr/share/licenses/perl-Sub-HandlesVia-XS/LICENSE
> I think there is missine "BuildArch:      noarch" to "%package tests"
> section.
Updated spec.

Updated files on the same links.

Comment 3 Michal Josef Spacek 2026-02-23 09:47:07 UTC
> > BuildRequires:
> > There are "perl(File::Copy)" and "perl(File::Spec)" which are not required,
> > this is for usage without ExtUtils::Constant.
> The modules are loaded by using 'use' and it caused that modules are imported in compile time.
> The module is not imported only when 'if' is used as part of 'use' function. That is not this
> case.

Ach, you are right.

Comment 4 Michal Josef Spacek 2026-02-23 09:48:07 UTC
Incorrect FSF address issue: https://github.com/tobyink/p5-sub-handlesvia-xs/issues/2

Comment 5 Michal Josef Spacek 2026-02-23 09:52:35 UTC
$ rpmlint ./perl-Sub-HandlesVia-XS*
perl-Sub-HandlesVia-XS-tests.noarch: W: no-documentation
perl-Sub-HandlesVia-XS.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Sub-HandlesVia-XS/LICENSE
= 5 packages and 1 specfiles checked; 1 errors, 1 warnings, 21 filtered, 1 badness; has taken 0.5 s =

Package looks good now.

Resolution:
Approved

Comment 6 Fedora Admin user for bugzilla script actions 2026-02-23 10:55:24 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Sub-HandlesVia-XS

Comment 7 Fedora Update System 2026-02-23 12:23:40 UTC
FEDORA-2026-6077e64404 (perl-Sub-HandlesVia-XS-0.003004-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-6077e64404

Comment 8 Fedora Update System 2026-02-24 01:15:23 UTC
FEDORA-2026-6077e64404 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-6077e64404`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-6077e64404

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2026-03-07 00:25:08 UTC
FEDORA-2026-6077e64404 (perl-Sub-HandlesVia-XS-0.003004-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.