Bug 243951 (pbm2l7k-review)

Summary:	Review Request: pbm2l7k - Converts PBM stream to Lexmark 7000, 7200 and 5700 printer language
Product:	[Fedora] Fedora	Reporter:	Lubomir Kundrak <lkundrak>
Component:	Package Review	Assignee:	Marek Mahut <mmahut>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mmahut, twaugh
Target Milestone:	---	Keywords:	HardwareEnablement
Target Release:	---	Flags:	mmahut: fedora-review+ j: fedora-cvs+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-07-02 09:48:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lubomir Kundrak 2007-06-12 22:01:47 UTC

Spec URL: http://people.redhat.com/lkundrak/SPECS/pbm2l7k.spec
SRPM URL: http://people.redhat.com/lkundrak/SRPMS/pbm2l7k-990321-1.src.rpm
Description: Converts bitcmyk data to Lexmark 2050 printer language

This is a filter to convert pbmraw data such as produced by ghostscript to
the printer language of Lexmark 7000, 7200 and 5700 printers.  It is meant
to be used by the PostScript Description files of the drivers from the
foomatic package.

Note: This package is a part of the ongoing effort to extend hardware support
by fixing the foomatic drivers that actually refer to external filters.

Comment 1 Marek Mahut 2007-06-13 21:34:30 UTC

Your symlink isn't relative, the compilation on my machine failed for this reason

   RPM build errors:
      File not found: /var/tmp/pbm2l7k-990321-1.fc7-root-root/usr/bin/pbm2lex

you should use the following entry for relative symlink

    %{__ln_s} pbm2l7k $RPM_BUILD_ROOT/%{_bindir}/pbm2lex

Comment 2 Lubomir Kundrak 2007-06-13 21:50:52 UTC

Thanks Marek. You suggestion has been incorporated in the current version of
the package.

Comment 3 Lubomir Kundrak 2007-06-20 20:33:18 UTC

New Package CVS Request
=======================
Package Name: pbm2l7k
Short Description: Converts PBM stream to Lexmark 7000, 7200 and 5700 printer
language
Owners: lkundrak
Branches: FC-6 F-7

Comment 4 Josh Boyer 2007-06-20 20:50:20 UTC

this hasn't been properly reviewed yet.

Comment 5 Marek Mahut 2007-06-28 22:11:10 UTC

+ source files match upstream:
         0f255d21fa2608094a2e40f5130ceee1 
/usr/src/redhat/SOURCES/lexmark7000linux-990321.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ license field matches the actual license.
+ license is open source-compatible.  
+ latest version is being packaged.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
+ rpmlint is silent.
+ final provides and requires are sane:
  [root@storm pbm2l7k]# rpm -qp --provides
/usr/src/redhat/RPMS/i386/pbm2l7k-990321-1.fc8.i386.rpm
  pbm2l7k = 990321-1.fc8
  [root@storm pbm2l7k]# rpm -qp --requires
/usr/src/redhat/RPMS/i386/pbm2l7k-990321-1.fc8.i386.rpm
  libc.so.6  
  libc.so.6(GLIBC_2.0)  
  libc.so.6(GLIBC_2.1)  
  libc.so.6(GLIBC_2.3.4)  
  libc.so.6(GLIBC_2.4)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rtld(GNU_HASH)  
  [root@storm pbm2l7k]# 
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.


APPROVED

Comment 6 Jason Tibbitts 2007-07-01 15:42:55 UTC

CVS done (last night; my connection has been extremely poor lately)

Comment 7 Lubomir Kundrak 2007-07-02 09:48:37 UTC

Thanks Marek and Jason. The package was imported into CVS.