Bug 2443680
| Summary: | Review Request: rust-icns - Library for encoding/decoding Apple Icon Image (.icns) files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review?
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://crates.io/crates/icns | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2443679 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Davide Cavalca
2026-03-01 19:47:18 UTC
$ cat rust2rpm.toml [tests] run = ["lib", "doc", "test:golden"] skip.'test:golden' = ["encode_ic07"] skip-exact.'test:golden' = true comments.'test:golden' = ["encode_ic07 fails due to non-deterministic PNG encoding output"] Copr build: https://copr.fedorainfracloud.org/coprs/build/10181350 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443680-rust-icns/fedora-rawhide-x86_64/10181350-rust-icns/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks mostly good to me, with one caveat: There's what looks like input data for tests under tests/icns / tests/png that looks like it's a "✓" icon from some icon theme. I'm not sure if this can be included without attribution (or license), and I don't see any mentions of where these files are from. Filed https://github.com/mdsteele/rust-icns/issues/14 for this, I'll strip it out in %prep in the meantime. Spec URL: https://dcavalca.fedorapeople.org/review/rust-icns/rust-icns.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-icns/rust-icns-0.4.0-1.fc45.src.rpm Changelog: - drop test assets of unknown provenance $ cat rust2rpm.toml [package] cargo-toml-patch-comments = [ "Drop golden test: https://github.com/mdsteele/rust-icns/issues/14", ] [scripts] # https://github.com/mdsteele/rust-icns/issues/14 prep.pre = [ "rm -r tests", ] Copr build: https://copr.fedorainfracloud.org/coprs/build/10218169 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443680-rust-icns/fedora-rawhide-x86_64/10218169-rust-icns/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://dcavalca.fedorapeople.org/review/rust-icns/rust-icns.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-icns/rust-icns-0.4.0-1.fc45.src.rpm Changelog: - update license tag to include test assets $ cat rust2rpm.toml [package] cargo-toml-patch-comments = [ "Update license tag to include golden file test assets", "https://github.com/mdsteele/rust-icns/issues/14", ] [tests] run = ["lib", "doc", "test:golden"] skip.'test:golden' = ["encode_ic07"] skip-exact.'test:golden' = true comments.'test:golden' = ["encode_ic07 fails due to non-deterministic PNG encoding output"] Created attachment 2133369 [details]
The .spec file difference from Copr build 10218169 to 10224770
Copr build: https://copr.fedorainfracloud.org/coprs/build/10224770 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443680-rust-icns/fedora-rawhide-x86_64/10224770-rust-icns/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks for clarifying with upstream. According to https://openclipart.org/share they actually explicitly apply CC0-1.0 to their content, not "Public Domain". I would suggest to just document this in the spec file, and `%exclude %{crate_instdir}/tests/{icns,png}/` instead of modifying the License tag. And you can drop the patch for the `Cargo.toml` package.license field - test data does not affect the crate license when used as a dependency. |