Bug 2443679 - Review Request: rust-hayro-jpeg2000 - Memory-safe, pure-Rust JPEG 2000 decoder
Summary: Review Request: rust-hayro-jpeg2000 - Memory-safe, pure-Rust JPEG 2000 decoder
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/hayro-jpeg2000
Whiteboard:
Depends On: 2443677
Blocks: 2443680
TreeView+ depends on / blocked
 
Reported: 2026-03-01 19:39 UTC by Davide Cavalca
Modified: 2026-03-06 22:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review?


Attachments (Terms of Use)

Description Davide Cavalca 2026-03-01 19:39:32 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-hayro-jpeg2000/rust-hayro-jpeg2000.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-hayro-jpeg2000/rust-hayro-jpeg2000-0.3.2-1.fc45.src.rpm
Upstream URL: https://crates.io/crates/hayro-jpeg2000

Description:
A memory-safe, pure-Rust JPEG 2000 decoder.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2026-03-01 19:40:16 UTC
$ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "Bump fearless_simd to 0.4",
  "Temporarily downgrade moxcms to 0.7.5",
  "Bump indicatif to 0.18",
]
extra-patches = [
  { number = 2, file = "Upgrade-to-fearless_simd-v0.4.patch", comments = ["https://github.com/LaurenzV/hayro/pull/948"] },
]

[tests]
run = ["lib", "doc"]
comments = ["Skip tests that require external assets"]

Comment 2 Fedora Review Service 2026-03-01 19:41:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10181346
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443679-rust-hayro-jpeg2000/fedora-rawhide-x86_64/10181346-rust-hayro-jpeg2000/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2026-03-06 22:11:47 UTC
I "accidentally" looked into packaging this crate too (glycin added a dependency on it) and found some minor issues:

- There's a bunch of files included that should probably be excluded from published crates.
  I filed https://github.com/LaurenzV/hayro/issues/1036 for this.

- The assets/*.icc files are covered by CC0-1.0 (text included in assets/LICENSE.txt).
  I am unsure about how to best represent this in crate / package metadata.
  These ICC profiles *do* get embedded into the library when building,
  so it does affect both dependent applications *and* the license of the source code shipped in rust-hayro-jpeg2000-devel.
  As far as I can tell, we will need a patch for Cargo.toml to change the license filed to `("MIT OR Apache-2.0) AND CC0-1.0"`.

As for the other changes to Cargo.toml:

- I'll try to get moxcms updated in Fedora.
- The "indicatif" dev-dependency can be dropped and doesn't need to be bumped, it is only used in skipped tests.


Note You need to log in before you can comment on or make changes to this bug.