Bug 2444098
| Summary: | Review Request: python-fastmcp - The fast, Pythonic way to build MCP servers and clients. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rodolfo Olivieri <rodolfo.olivieri3> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lemenkov, package-review, prgutier |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://gofastmcp.com | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-03-17 14:45:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2440706, 2443838 | ||
| Bug Blocks: | |||
|
Description
Rodolfo Olivieri
2026-03-03 13:09:30 UTC
This package depends on https://src.fedoraproject.org/rpms/python-fakeredis/pull-request/2 and is currently in review. Once this get merged, the builds should start to pass (at least, for rawhide). Successful build on my COPR using the builds of python-cyclopts and python-pydocket (on the Depends On): Logs: https://download.copr.fedorainfracloud.org/results/r0x0d/python-fastmcp/fedora-rawhide-x86_64/10186715-python-fastmcp/builder-live.log.gz Build: https://copr.fedorainfracloud.org/coprs/r0x0d/python-fastmcp/build/10186715/ Copr build: https://copr.fedorainfracloud.org/coprs/build/10189676 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2444098-python-fastmcp/fedora-rawhide-x86_64/10189676-python-fastmcp/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Posting again since python-pydocket landed in rawhide: Spec URL: https://r0x0d.fedorapeople.org/python-fastmcp/python-fastmcp.spec SRPM URL: https://r0x0d.fedorapeople.org/python-fastmcp/python-fastmcp-2.14.5-2.fc45.src.rpm I am using it daily so I'm very interested in including it to Fedora. I'll review it. Please, fix small warning - "Summary ended with dot". I don't see a huge issue so here is my formal
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license (Apache-2.0).
[x]: License file installed when any subpackage combination is installed.
[x]: Package owns all directories that it creates.
[x]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package does not contain desktop file (not a GUI application).
[-]: No separate development files
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: The package is not a rename of another package.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package does not contain systemd file(s).
[x]: Package is not known to require an ExcludeArch tag.
[-]: No extremely large documentation files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: No need for fully versioned dependency in subpackages.
[?]: I did not test if the package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources weren't verified with gpgverify.
[?]: I did not test if the package compiles and builds into binary rpms
on all supported architectures. It's a noarch package anyway.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Rpmlint is run on all installed packages.
Note: Mock build failed
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_use_rpmlint
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
Installation errors
-------------------
INFO: mock.py version 6.6 starting (python version = 3.14.3, NVR = mock-6.6-1.fc43), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/petro/work/RPMS/wxGTK/2444098-python-fastmcp/results install /home/petro/work/RPMS/wxGTK/2444098-python-fastmcp/results/python3-fastmcp+openai-2.14.5-2.fc45.noarch.rpm /home/petro/work/RPMS/wxGTK/2444098-python-fastmcp/results/python3-fastmcp-2.14.5-2.fc45.noarch.rpm
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Mock Version: 6.6
INFO: Mock Version: 6.6
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: Package manager dnf5 detected and used (fallback)
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
INFO: Package manager dnf5 detected and used (direct choice)
Finish: chroot init
INFO: installing package(s): /builddir/python3-fastmcp+openai-2.14.5-2.fc45.noarch.rpm /builddir/python3-fastmcp-2.14.5-2.fc45.noarch.rpm
ERROR: Command failed:
# /usr/bin/systemd-nspawn -q -M 3ec1bee87ccf4a2e8bb88aed96ef8698 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.yq590vg8:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 45 install /builddir/python3-fastmcp+openai-2.14.5-2.fc45.noarch.rpm /builddir/python3-fastmcp-2.14.5-2.fc45.noarch.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts
^^^ I guess not every mirror is synced. I'd ignore it.
Rpmlint
-------
Checking: python3-fastmcp-2.14.5-2.fc45.noarch.rpm
python3-fastmcp+openai-2.14.5-2.fc45.noarch.rpm
python-fastmcp-2.14.5-2.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp3t3otg1d')]
checks: 32, packages: 3
python-fastmcp.src: W: summary-ended-with-dot The fast, Pythonic way to build MCP servers and clients.
python3-fastmcp.noarch: W: summary-ended-with-dot The fast, Pythonic way to build MCP servers and clients.
^^^ See my note above.
python-fastmcp.src: E: spelling-error ('auth', '%description -l en_US auth -> auto, Ruth, author')
python3-fastmcp.noarch: W: no-manual-page-for-binary fastmcp
3 packages and 0 specfiles checked; 1 errors, 3 warnings, 35 filtered, 1 badness; has taken 1.8 s
Source checksums
----------------
https://files.pythonhosted.org/packages/source/f/fastmcp/fastmcp-2.14.5.tar.gz :
CHECKSUM(SHA256) this package : 38944dc582c541d55357082bda2241cedb42cd3a78faea8a9d6a2662c62a42d7
CHECKSUM(SHA256) upstream package : 38944dc582c541d55357082bda2241cedb42cd3a78faea8a9d6a2662c62a42d7
Requires
--------
python3-fastmcp (rpmlib, GLIBC filtered):
(python3.14dist(authlib) < 1.6.5~~ with python3.14dist(authlib) >= 1.4)
(python3.14dist(mcp) < 2~~ with python3.14dist(mcp) >= 1.24)
(python3.14dist(py-key-value-aio) < 0.4~~ with python3.14dist(py-key-value-aio) >= 0.3)
(python3.14dist(py-key-value-aio[disk]) < 0.4~~ with python3.14dist(py-key-value-aio[disk]) >= 0.3)
(python3.14dist(py-key-value-aio[keyring]) < 0.4~~ with python3.14dist(py-key-value-aio[keyring]) >= 0.3)
(python3.14dist(py-key-value-aio[memory]) < 0.4~~ with python3.14dist(py-key-value-aio[memory]) >= 0.3)
(python3.14dist(pyperclip) < 1.9~~ with python3.14dist(pyperclip) >= 1.8.2)
/usr/bin/python3
python(abi)
python3.14dist(cyclopts)
python3.14dist(exceptiongroup)
python3.14dist(httpx)
python3.14dist(jsonref)
python3.14dist(jsonschema-path)
python3.14dist(openapi-pydantic)
python3.14dist(packaging)
python3.14dist(platformdirs)
python3.14dist(pydantic)
python3.14dist(pydantic[email])
python3.14dist(pydocket)
python3.14dist(python-dotenv)
python3.14dist(rich)
python3.14dist(uvicorn)
python3.14dist(websockets)
python3-fastmcp+openai (rpmlib, GLIBC filtered):
python(abi)
python3-fastmcp
python3.14dist(openai)
Provides
--------
python3-fastmcp:
python-fastmcp
python3-fastmcp
python3.14-fastmcp
python3.14dist(fastmcp)
python3dist(fastmcp)
python3-fastmcp+openai:
python-fastmcp+openai
python3-fastmcp+openai
python3.14-fastmcp+openai
python3.14dist(fastmcp[openai])
python3dist(fastmcp[openai])
Please fix cosmetic issue with Summary field before uploading. This package is
================
=== APPROVED ===
================
Oh, for sure! Thanks a lot for the review, Peter. The Pagure repository was created at https://src.fedoraproject.org/rpms/python-fastmcp FEDORA-2026-a110b76945 (python-fastmcp-2.14.5-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-a110b76945 FEDORA-2026-a110b76945 (python-fastmcp-2.14.5-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report. (In reply to Rodolfo Olivieri from comment #7) > Oh, for sure! Thanks a lot for the review, Peter. Don;t forget to build it for current branches (f44, f43, maybe f42, but I am not sure about the latter). (In reply to Peter Lemenkov from comment #11) > (In reply to Rodolfo Olivieri from comment #7) > > Oh, for sure! Thanks a lot for the review, Peter. > > Don;t forget to build it for current branches (f44, f43, maybe f42, but I am > not sure about the latter). Yeah! f42 is EOL already, so it will be f44 and f43. Currently, I'm waiting on the bodhi update for python-pydocket to land in F43 and F44 for me to trigger the build, but I have it noted here to not forget. It is also crucial for my team that we ship in those versions too. (In reply to Rodolfo Olivieri from comment #12) > (In reply to Peter Lemenkov from comment #11) > > (In reply to Rodolfo Olivieri from comment #7) > > > Oh, for sure! Thanks a lot for the review, Peter. > > > > Don;t forget to build it for current branches (f44, f43, maybe f42, but I am > > not sure about the latter). > > Yeah! f42 is EOL already, so it will be f44 and f43. Currently, I'm waiting > on the bodhi update for python-pydocket to land in F43 and F44 for me to > trigger the build, but I have it noted here to not forget. It is also > crucial for my team that we ship in those versions too. I see all dependencies hit stable repositories so please do a builds for f43/44! :) (In reply to Peter Lemenkov from comment #13) > (In reply to Rodolfo Olivieri from comment #12) > > (In reply to Peter Lemenkov from comment #11) > > > (In reply to Rodolfo Olivieri from comment #7) > > > > Oh, for sure! Thanks a lot for the review, Peter. > > > > > > Don;t forget to build it for current branches (f44, f43, maybe f42, but I am > > > not sure about the latter). > > > > Yeah! f42 is EOL already, so it will be f44 and f43. Currently, I'm waiting > > on the bodhi update for python-pydocket to land in F43 and F44 for me to > > trigger the build, but I have it noted here to not forget. It is also > > crucial for my team that we ship in those versions too. > > I see all dependencies hit stable repositories so please do a builds for > f43/44! :) Ping, Rodolfo! Looks like all deps are available! :) FEDORA-2026-75361ad803 (python-fastmcp-2.14.5-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-75361ad803 FEDORA-2026-1fbe5ce5f2 (python-fastmcp-2.14.5-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-1fbe5ce5f2 FEDORA-2026-1fbe5ce5f2 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-1fbe5ce5f2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-1fbe5ce5f2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-75361ad803 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-75361ad803 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-75361ad803 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-1fbe5ce5f2 (python-fastmcp-2.14.5-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2026-75361ad803 (python-fastmcp-2.14.5-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |