Spec URL: https://download.copr.fedorainfracloud.org/results/r0x0d/python-cyclopts/fedora-rawhide-x86_64/10148988-python-cyclopts/python-cyclopts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/r0x0d/python-cyclopts/fedora-rawhide-x86_64/10148988-python-cyclopts/python-cyclopts-4.5.3-1.fc45.src.rpm Description: Cyclopts is a modern, easy-to-use command-line interface (CLI) framework that aims to provide an intuitive & efficient developer experience. Fedora Account System Username: r0x0d
Copr build: https://copr.fedorainfracloud.org/coprs/build/10148991 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2440706-python-cyclopts/fedora-rawhide-x86_64/10148991-python-cyclopts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
hi, i might take the review on this one. can you please post the original spec file? the one you posted looks like it has been mangled by rpmautospec already.
Hi, Tobi! Here's the original srpm/spec SPEC URL: https://r0x0d.fedorapeople.org/python-cyclopts/python-cyclopts.spec SRPM URL: https://r0x0d.fedorapeople.org/python-cyclopts/python-cyclopts-4.5.3-1.fc45.src.rpm
Created attachment 2130612 [details] The .spec file difference from Copr build 10148991 to 10159265
Copr build: https://copr.fedorainfracloud.org/coprs/build/10159265 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2440706-python-cyclopts/fedora-rawhide-x86_64/10159265-python-cyclopts/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I believe the build is failing because of a missing SETUPTOOLS_SCM_PRETEND_VERSION_FOR_CYCLOPTS declaration in the %generate_buildrequires section. And I'm assuming you're using the github sources instead of pypi tarballs because the latter doesn't include tests; is that right?
there are more things wrong with the latest specfile. please let me know when you fixed the build and i can continue reviewing. :)