Bug 2445222
| Summary: | Review Request: rust-gio-unix-sys - FFI bindings to libgio-2.0 Unix APIs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | blinxen <h-k-81> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | h-k-81, package-review |
| Target Milestone: | --- | Flags: | h-k-81:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/gio-unix-sys | ||
| Whiteboard: | |||
| Fixed In Version: | rust-gio-unix-sys-0.22.0-1.fc45 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-03-11 23:46:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2445223 | ||
|
Description
Fabio Valentini
2026-03-06 14:14:59 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=143080790 The bindings for gio-unix-2.0 were split off from the gio-2.0 bindings in v0.22.0. rust2rpm.toml configuration (based on the rust-gio-sys package): ``` [features] hide = [ ] [requires] build = ["pkgconfig(gio-unix-2.0) >= 2.56"] lib = ["pkgconfig(gio-unix-2.0) >= 2.56"] features.v2_58 = ["pkgconfig(gio-unix-2.0) >= 2.58"] features.v2_60 = ["pkgconfig(gio-unix-2.0) >= 2.60"] features.v2_66 = ["pkgconfig(gio-unix-2.0) >= 2.66"] features.v2_82 = ["pkgconfig(gio-unix-2.0) >= 2.82"] features.v2_84 = ["pkgconfig(gio-unix-2.0) >= 2.84"] ``` Copr build: https://copr.fedorainfracloud.org/coprs/build/10197576 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445222-rust-gio-unix-sys/fedora-rawhide-x86_64/10197576-rust-gio-unix-sys/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. One minor comment regarding the default feature, should it also have `Requires: pkgconfig(gio-unix-2.0) >= 2.56` just to be consistent with the other features?. Thank you for the review!
> One minor comment regarding the default feature, should it also have `Requires: pkgconfig(gio-unix-2.0) >= 2.56` just to be consistent with the other features?.
No, this would be a noop. The -devel feature already has this dependency, which is pulled in by all +feature-devel subpackages (including the +default-devel one).
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gio-unix-sys Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2026-5c5aa96199 |