Bug 2445222 - Review Request: rust-gio-unix-sys - FFI bindings to libgio-2.0 Unix APIs
Summary: Review Request: rust-gio-unix-sys - FFI bindings to libgio-2.0 Unix APIs
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: blinxen
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/gio-unix-sys
Whiteboard:
Depends On:
Blocks: 2445223
TreeView+ depends on / blocked
 
Reported: 2026-03-06 14:14 UTC by Fabio Valentini
Modified: 2026-03-11 23:46 UTC (History)
2 users (show)

Fixed In Version: rust-gio-unix-sys-0.22.0-1.fc45
Clone Of:
Environment:
Last Closed: 2026-03-11 23:46:24 UTC
Type: ---
Embargoed:
h-k-81: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2026-03-06 14:14:59 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-gio-unix-sys.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-gio-unix-sys-0.22.0-1.fc43.src.rpm
Upstream URL: https://crates.io/crates/gio-unix-sys

Description:
FFI bindings to libgio-2.0 Unix APIs.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2026-03-06 14:15:02 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=143080790

Comment 2 Fabio Valentini 2026-03-06 14:18:06 UTC
The bindings for gio-unix-2.0 were split off from the gio-2.0 bindings in v0.22.0.

rust2rpm.toml configuration (based on the rust-gio-sys package):

```
[features]
hide = [
]

[requires]
build = ["pkgconfig(gio-unix-2.0) >= 2.56"]
lib = ["pkgconfig(gio-unix-2.0) >= 2.56"]
features.v2_58 = ["pkgconfig(gio-unix-2.0) >= 2.58"]
features.v2_60 = ["pkgconfig(gio-unix-2.0) >= 2.60"]
features.v2_66 = ["pkgconfig(gio-unix-2.0) >= 2.66"]
features.v2_82 = ["pkgconfig(gio-unix-2.0) >= 2.82"]
features.v2_84 = ["pkgconfig(gio-unix-2.0) >= 2.84"]
```

Comment 3 Fedora Review Service 2026-03-06 14:22:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10197576
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445222-rust-gio-unix-sys/fedora-rawhide-x86_64/10197576-rust-gio-unix-sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 blinxen 2026-03-11 20:49:43 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

One minor comment regarding the default feature, should it also have `Requires:       pkgconfig(gio-unix-2.0) >= 2.56` just to be consistent with the other features?.

Comment 5 Fabio Valentini 2026-03-11 23:30:31 UTC
Thank you for the review!

> One minor comment regarding the default feature, should it also have `Requires:       pkgconfig(gio-unix-2.0) >= 2.56` just to be consistent with the other features?.

No, this would be a noop. The -devel feature already has this dependency, which is pulled in by all +feature-devel subpackages (including the +default-devel one).

Comment 6 Fedora Admin user for bugzilla script actions 2026-03-11 23:31:06 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gio-unix-sys

Comment 7 Fabio Valentini 2026-03-11 23:46:24 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2026-5c5aa96199


Note You need to log in before you can comment on or make changes to this bug.