Bug 2445693

Summary: Review Request: sso-mib - Tools and library for Single-Sign-On with CA for Entra via Himmelblau
Product: [Fedora] Fedora Reporter: Zbigniew Jędrzejewski-Szmek <zbyszek>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: luca.boccassi, ngompa13, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: ngompa13: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/siemens/sso-mib
Whiteboard:
Fixed In Version: sso-mib-0.7.0-3.fc45 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-03-19 19:54:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zbigniew Jędrzejewski-Szmek 2026-03-09 07:05:47 UTC 
Spec URL: https://zbyszek.fedorapeople.org/reviews/sso-mib/sso-mib.spec
SRPM URL: https://zbyszek.fedorapeople.org/reviews/sso-mib/sso-mib-0.7.0-2.fc45.src.rpm

Description:
Applications can link with this library to get Entra Conditional Access tokens
for authentication and Single-Sign-On from the Himmelblau stack.

Fedora Account System Username: zbyszek
Comment 1 Fedora Review Service 2026-03-09 08:35:10 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10203056
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445693-sso-mib/fedora-rawhide-x86_64/10203056-sso-mib/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Neal Gompa 2026-03-19 19:28:11 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correct, license data is correctly installed
* Package has no serious issues detected by rpmlint

A couple of packaging things to update, though:

> %build
> %meson
> %meson_build

Unless you need to support EPEL9 and older, please consider splitting this into %conf and %build sections like so:

%conf
%meson

%build
%meson_build

> Enhances:       git

This should be "Enhances: git-core" instead.


I'm fine with these being resolved on import, though.

PACKAGE APPROVED.
Comment 3 Zbigniew Jędrzejewski-Szmek 2026-03-19 19:33:26 UTC 
That was quick! Thanks!
Comment 4 Fedora Admin user for bugzilla script actions 2026-03-19 19:36:49 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/sso-mib