Bug 2447590
| Summary: | Review Request: python-sqlmodel - SQL databases in Python, designed for simplicity, compatibility, and robustness | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> |
| Component: | Package Review | Assignee: | Benson Muite <benson_muite> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | benson_muite, package-review |
| Target Milestone: | --- | Flags: | benson_muite:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-04-23 01:08:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941, 2447451 | ||
|
Description
Ben Beasley
2026-03-14 07:31:27 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. spec: https://music.fedorapeople.org/python-sqlmodel.spec srpm: https://music.fedorapeople.org/python-sqlmodel-0.0.37-1.fc43.src.rpm Fixed the wrong package name in the bug title. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/10227349 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2447590-python-sqlmodel/fedora-rawhide-x86_64/10227349-python-sqlmodel/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-sqlmodel Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-sqlmodel See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License". 409 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-sqlmodel/2447590- python-sqlmodel/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14/site- packages, /usr/lib/python3.14 [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9121 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-sqlmodel-0.0.37-1.fc45.noarch.rpm python-sqlmodel-0.0.37-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphk307zab')] checks: 32, packages: 2 python3-sqlmodel.noarch: W: obsolete-not-provided python3-sqlmodel-slim 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 18 filtered, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-sqlmodel.noarch: W: obsolete-not-provided python3-sqlmodel-slim 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 14 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/fastapi/sqlmodel/archive/0.0.37/sqlmodel-0.0.37.tar.gz : CHECKSUM(SHA256) this package : 89f572c4f3eccd57c9a8e1483e51cbb23389a3ea29265d3a6071f37d735f6c05 CHECKSUM(SHA256) upstream package : 89f572c4f3eccd57c9a8e1483e51cbb23389a3ea29265d3a6071f37d735f6c05 Requires -------- python3-sqlmodel (rpmlib, GLIBC filtered): (python3.14dist(sqlalchemy) < 2.1~~ with python3.14dist(sqlalchemy) >= 2.0.14) python(abi) python3.14dist(pydantic) python3.14dist(typing-extensions) Provides -------- python3-sqlmodel: python-sqlmodel python3-sqlmodel python3.14-sqlmodel python3.14dist(sqlmodel) python3dist(sqlmodel) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2447590 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: SugarActivity, C/C++, Java, R, PHP, Perl, Haskell, Ocaml, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Approved. b) Review of one of: https://bugzilla.redhat.com/show_bug.cgi?id=2449983 https://bugzilla.redhat.com/show_bug.cgi?id=2439289 would be appreciated if time allows Thank you for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sqlmodel FEDORA-2026-f4d8c6e22d (python-snakemake-interface-storage-plugins-4.4.1-1.fc44, python-sqlmodel-0.0.37-1.fc44, and 1 more) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d FEDORA-2026-bac21d9f77 (python-snakemake-interface-storage-plugins-4.4.1-1.fc43, python-sqlmodel-0.0.37-1.fc43, and 1 more) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-bac21d9f77 FEDORA-2026-f4d8c6e22d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4d8c6e22d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-bac21d9f77 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-bac21d9f77` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bac21d9f77 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-bac21d9f77 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-bac21d9f77` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bac21d9f77 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-bac21d9f77 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-bac21d9f77` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bac21d9f77 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-f4d8c6e22d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4d8c6e22d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-f4d8c6e22d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4d8c6e22d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-bac21d9f77 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-bac21d9f77` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bac21d9f77 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-f4d8c6e22d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4d8c6e22d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-bac21d9f77 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-bac21d9f77` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bac21d9f77 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-f4d8c6e22d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4d8c6e22d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-bac21d9f77 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-bac21d9f77` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bac21d9f77 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-f4d8c6e22d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4d8c6e22d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-f4d8c6e22d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4d8c6e22d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-bac21d9f77 (fastapi-cloud-cli-0.16.1-1.fc43, python-fastar-0.11.0-1.fc43, and 5 more) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2026-f4d8c6e22d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4d8c6e22d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4d8c6e22d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-8b3a9f21ad (fastapi-cloud-cli-0.17.0-1.fc44, python-fastapi-0.136.1-1.fc44, and 9 more) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-8b3a9f21ad FEDORA-2026-8b3a9f21ad (fastapi-cloud-cli-0.17.0-1.fc44, python-fastapi-0.136.1-1.fc44, and 9 more) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. |