Bug 2450077

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10253067
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450077-python-osc-placement/fedora-rawhide-x86_64/10253067-python-osc-placement/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hi Steve,

wouldn't it be good to replace all "python3" occurrences with "python%{python3_pkgversion}" and add an additional

BuildRequires:    python-srpm-macros

This would allow for easier porting/building package for different python versions. See:

https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/installing_and_using_dynamic_programming_languages/assembly_packaging-python-3-rpms_installing-and-using-dynamic-programming-languages

Hi Andreas,

Thanks for the review.

> wouldn't it be good to replace all "python3" occurrences with "python%{python3_pkgversion}" and add an additional

Sure will change at next iteration.

> BuildRequires:    python-srpm-macros

This is pulled in anyway by python3-devel. If older OSes don't I will deal with that in that branch. I don't want to add redundant stuff here. More generally I'd say that redhat.com page is outdated using deprecated in fedora %py3_ macros. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_time_dependency_on_python3_devel wins.

I've also patched python-cliff now https://src.fedoraproject.org/rpms/python-cliff/c/c047cd892d468d6f9b13a23bf17ddb063eba989d?branch=rawhide so docs can be generated on on > py3.14. However it uncovered a missing dependency, python-sphinx-feature-classification, which is needed to do docs. Will add that first. Have blocked this on the review of that.

Okay I've got bored waiting for the docs dependency to happen.
Having this package is more important to me than having the docs for this package.

Spec URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement-4.8.0-1.fc43.src.rpm

There seems to be some problem with the following file.
SRPM URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement-4.8.0-1.fc43.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

May want to use patches rather than sed, but not a must.

I prefer the seds for these - those seds will live forever.

Building the docs has been added back now with availability of the dependency.

There's an rpmlint warning about duplicate files but that is a thing to solve in sphinx really.
https://github.com/sphinx-doc/sphinx/issues/13734


Spec URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement-4.8.0-1.fc43.src.rpm

Try again:

fedora-review-service-build

or ...

[fedora-review-service-build]

Spec URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement-4.8.0-1.fc43.src.rpm

I guess python devel BR should be this, right?

BuildRequires:    python%{python3_pkgversion}-devel

(In reply to Andreas Haupt from comment #10)
> I guess python devel BR should be this, right?
> 
> BuildRequires:    python%{python3_pkgversion}-devel

I thought it would be a bootstrap problem but does indeed work.

Spec URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-osc-placement/python-osc-placement-4.8.0-1.fc45.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10359435
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450077-python-osc-placement/fedora-rawhide-x86_64/10359435-python-osc-placement/fedora-review/review.txt

Found issues:

- License file license.png is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
- Documentation size is 4555308 bytes in 78 files. 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

License is missing:

%license LICENSE

See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text


There are build failures on older Fedoras:

No match for argument: python3dist(sphinx-feature-classification) >= 0.2

I guess, you do not want to have the package on F43, right?

> License is missing:

Until recently I would have agreed with you however see for example comment "c" at the end of

https://bugzilla.redhat.com/show_bug.cgi?id=2452955#c6

In particular the %pyproject_save_files is smart enough to mark the LICENSE as a LICENSE from python metadata.
More over the `-l` flags instructs %pyproject_save_files to fail if the LICENSE can not be found.

So adding %license LICENSE results in a duplicate file.

> I guess, you do not want to have the package on F43, right?

I don't intend to release this for F43 , F44 is close enough though that is pending on:
https://bodhi.fedoraproject.org/updates/FEDORA-2026-d279b14c32

OK, then I give it a go!

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-osc-placement
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

FEDORA-2026-d1257d0590 (python-osc-placement-4.8.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-d1257d0590

FEDORA-2026-d1257d0590 (python-osc-placement-4.8.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.