Bug 2452955 - Review Request: python-sphinx-feature-classification - Generate a matrix of pluggable drivers
Summary: Review Request: python-sphinx-feature-classification - Generate a matrix of p...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL: https://docs.openstack.org/sphinx-fea...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-03-30 08:57 UTC by Steve Traylen
Modified: 2026-04-17 08:47 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-04-17 08:47:57 UTC
Type: ---
Embargoed:
benson_muite: fedora-review+


Attachments (Terms of Use)

Description Steve Traylen 2026-03-30 08:57:15 UTC
Spec URL: https://straylen.web.cern.ch/rpms/python-sphinx-feature-classification/python-sphinx-feature-classification.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-sphinx-feature-classification/python-sphinx-feature-classification-2.1.0-1.fc43.src.rpm
Description: Generate a matrix of pluggable drivers and their support to an API in Sphinx
Fedora Account System Username: stevetraylen

Comment 1 Fedora Review Service 2026-03-30 09:00:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10273445
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2452955-python-sphinx-feature-classification/fedora-rawhide-x86_64/10273445-python-sphinx-feature-classification/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Gonza 2026-03-31 15:56:29 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.
- License field mismatch: The licensecheck tool reports multiple licenses, including "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", and "Apache License 2.0". The spec file's `License:` tag is "Apache-2.0". This discrepancy needs to be resolved. Either the `License:` tag needs to be updated to accurately reflect all licenses present, or the unknown/generated licenses need to be clarified. (See Licensing Guidelines)
- Directory ownership: The package creates directories `/usr/lib/python3.14` and `/usr/lib/python3.14/site-packages` without explicitly owning them. The package must own all directories it creates. This can be fixed by adding these directories to the `%files` section. (See Filesystem Layout and Packaging Guidelines)



===== MUST items =====

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "*No copyright* Apache License", "Apache License 2.0". 36 files have
     unknown license. Detailed output of licensecheck in /tmp/rpm-reviewer-
     djn6myzn/2452955-python-sphinx-feature-classification/licensecheck.txt
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.14,
     /usr/lib/python3.14/site-packages
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 3531 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-sphinx-feature-classification-2.1.0-1.fc45.noarch.rpm
          python-sphinx-feature-classification-2.1.0-1.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_zcjkdwe')]
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 0.3 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/s/sphinx_feature_classification/sphinx_feature_classification-2.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : 7cf4316ac8283b9761ed956990538c3bfd98974878792e6ac1492de8828ca247
  CHECKSUM(SHA256) upstream package : 7cf4316ac8283b9761ed956990538c3bfd98974878792e6ac1492de8828ca247


Requires
--------
python3-sphinx-feature-classification (rpmlib, GLIBC filtered):
    python(abi)
    python3.14dist(docutils)
    python3.14dist(pbr)



Provides
--------
python3-sphinx-feature-classification:
    python-sphinx-feature-classification
    python3-sphinx-feature-classification
    python3.14-sphinx-feature-classification
    python3.14dist(sphinx-feature-classification)
    python3dist(sphinx-feature-classification)

Comment 3 Steve Traylen 2026-04-01 18:00:49 UTC
Thank you for the review:

Spec URL: https://straylen.web.cern.ch/rpms/python-sphinx-feature-classification/python-sphinx-feature-classification.spec
SRPM URL: https://straylen.web.cern.ch/rpms/python-sphinx-feature-classification/python-sphinx-feature-classification-2.1.0-1.fc43.src.rpm

Main change is I have now enabled the documentation build as I have patched cliff in rawhide for python3.15a.

Addressing your comments:

- Dist tag is present.

The release is 

Release: %{autorelease}

The is normal when  rpmautospec is in use with a spec using %autorelease, it is extended by the dist tag as per the .src.rpm name above.

Maybe you mean something else ?

- Directory ownership: The package creates directories `/usr/lib/python3.14` and `/usr/lib/python3.14/site-packages` without explicitly owning them. The package must own all directories it creates. This can be fixed by adding these directories to the `%files` section. (See Filesystem Layout and Packaging Guidelines)

The package requires:

   rpm -qp --requires ./results/python3-osc-placement-4.8.0-1.fc45.noarch.rpm 
   python(abi) = 3.14

and this bring in the python3-libs package which owns those directories. Significantly they will never be unowned.
d

-  License field mismatch:

This package is pretty well licensed I would say.

* LICENSE file is good
* pyproject.toml file is explicit

Most of the "real" source files have headers on as well.

The remaining files are things like .reno.conf  (used for tests) , pyproject.yaml belong in the not relevant category, these are build scripts.
There are certainly no files that contradict this is Apache-II all over.

Comment 4 Fedora Review Service 2026-04-01 18:05:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10284838
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2452955-python-sphinx-feature-classification/fedora-rawhide-x86_64/10284838-python-sphinx-feature-classification/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Steve Traylen 2026-04-02 07:24:03 UTC
I wanted to confirm the directory ownership since 

* This is a really normal python module
* I think that's a false positive in the checker that should be fixed.

On a rawhide node.

   $ rpm -qf /usr/lib/python3.14/site-packages
   error: file /usr/lib/python3.14/site-packages: No such file or directory

   dnf install $(rpm -qpR ./python3-osc-placement-4.8.0-1.fc44.noarch.rpm | cut -f1 -d' ' |grep -v rpmlib)

   rpm -qf /usr/lib/python3.14/site-packages
   python3-libs-3.14.3-2.fc45.x86_64

So that is good - this is a false positive in my opinion.

Comment 6 Benson Muite 2026-04-16 13:47:07 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "*No copyright* Apache License", "Apache License 2.0". 36 files have
     unknown license. Detailed output of licensecheck in
     /home/fedora-packaging/reviews/python-sphinx-feature-
     classification/2452955-python-sphinx-feature-
     classification/licensecheck.txt
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.14/site-
     packages, /usr/lib/python3.14
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 3531 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-sphinx-feature-classification-2.1.0-1.fc45.noarch.rpm
          python-sphinx-feature-classification-2.1.0-1.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp2jv26s4w')]
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 0.6 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-sphinx-feature-classification.noarch: E: spelling-error ('Generate', 'Summary(en_US) Generate ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('matrix', 'Summary(en_US) matrix ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('of', 'Summary(en_US) of ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('drivers', 'Summary(en_US) drivers ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('and', 'Summary(en_US) and -> 2nd')
python3-sphinx-feature-classification.noarch: E: spelling-error ('their', 'Summary(en_US) their ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('support', 'Summary(en_US) support ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('to', 'Summary(en_US) to ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('an', 'Summary(en_US) an ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('This', '%description -l en_US This ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('is', '%description -l en_US is -> i.e.')
python3-sphinx-feature-classification.noarch: E: spelling-error ('directive', '%description -l en_US directive ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('that', '%description -l en_US that ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('allows', '%description -l en_US allows ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('creating', '%description -l en_US creating ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('matrices', '%description -l en_US matrices ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('of', '%description -l en_US of ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('drivers', '%description -l en_US drivers ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('project', '%description -l en_US project ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('contains', '%description -l en_US contains ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('and', '%description -l en_US and -> 2nd')
python3-sphinx-feature-classification.noarch: E: spelling-error ('which', '%description -l en_US which ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('features', '%description -l en_US features ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('they', '%description -l en_US they ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('support', '%description -l en_US support ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('The', '%description -l en_US The -> 7th')
python3-sphinx-feature-classification.noarch: E: spelling-error ('takes', '%description -l en_US takes ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('an', '%description -l en_US an ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('file', '%description -l en_US file ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('with', '%description -l en_US with ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('specific', '%description -l en_US specific ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('syntax', '%description -l en_US syntax ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('explained', '%description -l en_US explained ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('the', '%description -l en_US the -> 7th')
python3-sphinx-feature-classification.noarch: E: spelling-error ('usage', '%description -l en_US usage ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('documentation', '%description -l en_US documentation ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('to', '%description -l en_US to ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('generate', '%description -l en_US generate ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('projects', '%description -l en_US projects ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('have', '%description -l en_US have ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('authority', '%description -l en_US authority ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('say', '%description -l en_US say ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('what', '%description -l en_US what ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('supported', '%description -l en_US supported ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('within', '%description -l en_US within ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('their', '%description -l en_US their ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('own', '%description -l en_US own ')
python3-sphinx-feature-classification.noarch: E: spelling-error ('repository', '%description -l en_US repository ')
 1 packages and 0 specfiles checked; 48 errors, 0 warnings, 7 filtered, 48 badness; has taken 0.1 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/s/sphinx_feature_classification/sphinx_feature_classification-2.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : 7cf4316ac8283b9761ed956990538c3bfd98974878792e6ac1492de8828ca247
  CHECKSUM(SHA256) upstream package : 7cf4316ac8283b9761ed956990538c3bfd98974878792e6ac1492de8828ca247


Requires
--------
python3-sphinx-feature-classification (rpmlib, GLIBC filtered):
    python(abi)
    python3.14dist(docutils)
    python3.14dist(pbr)



Provides
--------
python3-sphinx-feature-classification:
    python-sphinx-feature-classification
    python3-sphinx-feature-classification
    python3.14-sphinx-feature-classification
    python3.14dist(sphinx-feature-classification)
    python3dist(sphinx-feature-classification)



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2452955
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: C/C++, fonts, R, SugarActivity, Perl, PHP, Haskell, Ocaml, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=144505626

b) Not sure why getting spelling errors for contents of the common description.
They do not occur at:
https://copr.fedorainfracloud.org/coprs/fed500/python-sphinx-feature-classification/build/10339379/

c) License file does not need to be marked again as a license:
$ rpm -qL python3-sphinx-feature-classification-2.1.0-1.fc45.noarch.rpm
/usr/lib/python3.14/site-packages/sphinx_feature_classification-2.1.0.dist-info/licenses/AUTHORS
/usr/lib/python3.14/site-packages/sphinx_feature_classification-2.1.0.dist-info/licenses/LICENSE
/usr/share/licenses/python3-sphinx-feature-classification/LICENSE

please change

%doc README.rst ChangeLog
%license LICENSE
to
%doc README.rst ChangeLog

d) It may be helpful to package the documentation.
Example build with packaged documentation:
https://koji.fedoraproject.org/koji/taskinfo?taskID=144507572
https://copr.fedorainfracloud.org/coprs/fed500/python-sphinx-feature-classification/build/10339379/

e) Approved. Please fix (c) before import. Consider (d).

Comment 7 Steve Traylen 2026-04-16 18:34:53 UTC
Thankyou for the review - what is going on with the spelling there?

python3-sphinx-feature-classification.noarch: E: spelling-error ('say', '%description -l en_US say ')

.....

Comment 8 Fedora Admin user for bugzilla script actions 2026-04-16 18:37:46 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinx-feature-classification

Comment 9 Steve Traylen 2026-04-16 19:03:54 UTC
There is something weird in that .spec file.

```
fedpkg mockbuild
Could not execute mockbuild: Couldn’t parse spec file python-sphinx-feature-classification.spec:
Spec file is missing.
```

Will look tomorrow.... Possibly cause of spelling madness.

Comment 10 Fedora Update System 2026-04-17 08:37:17 UTC
FEDORA-2026-9d821c8e02 (python-sphinx-feature-classification-2.1.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-9d821c8e02

Comment 11 Fedora Update System 2026-04-17 08:47:57 UTC
FEDORA-2026-9d821c8e02 (python-sphinx-feature-classification-2.1.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.