Bug 245357

This is not an official review as I am not sponsored yet.


---------
Summary:
---------
* Does not build in mock, missing BuildRequires: pkgconfig
* Changelog needs some work
* %doc contains empty files

---------
Details:
---------

* FIX - Mock : Built on F-7 (x86)
        Did not build: (needs BuildRequires: pkgconfig
                checking for pkg-config... no
                checking for PACKAGE... configure: error: The pkg-config script
could not be found or is too old.  Make sure it
                is in your PATH or set the PKG_CONFIG environment variable to
the full
                path to pkg-config.

 OK - Package meets naming and packaging guidelines
 OK - Spec file matches base package name.
 OK - Spec has consistant macro usage.
 OK - License field in spec matches
 OK - License is GPL
 OK - License match packaging policy licenses allowed
 OK - License file is included in package
 OK - Spec in American English
 OK - Spec is legible.
 OK - Sources SHOULD match upstream md5sum:
8ffa3233ad28fb3ead324d88573f0c38  libopensync-plugin-syncml-0.22.tar.bz2
 OK - Package has correct buildroot.
 OK - BuildRequires are not redundant.
 FIX - %build and %install stages are correct and work.
        Does not build
 OK - Package has %defattr and permissions on files is good.
 OK - Package has a correct %clean section.
 OK - Package is code or permissible content.
 OK - Packages %doc files don't affect runtime.
 OK - No large doc files not in a -doc package
 OK - Package has no duplicate files in %files.
 FIX - Package %files & %doc looks good
        %doc contains empty files - README and NEWS
 ? - Package doesn't own any directories that other packages own.
 FIX - Changelog section is correct. 
        either needs a "-" infront of it or move it up to the above line
* NA - Does not contain any .la libtool archives
 NA - .desktop file installed correctly

 ? - Should function as described.
 OK - Should package latest version

---------------
Rpmlint output:
---------------
* SRPM
        OK - silent
* RPM
        ?- rpm didn't build

One more thing I forgot to put above:

The spec includes a -devel package, but does not contain a %files devel section. 

New srpm available at
http://www.nosuchhost.net/~cheese/fedora/packages/libopensync-plugin-syncml-0.
22-2.fc7.src.rpm

modified specfile according to your suggestions.
will have to use mockbuild, instead of building by hand.

I can't sponsor (have you e-mailed fedora-devel or ask on the IRC channel?), but
here's a quick review:

- License field is wrong. It is LGPL version 2.1 or above, which using the old
guideline would have been LGPL, and the new license guideline requires you to
state it as LGPLv2+

- Syncml should be capitalized properly: SyncML
- In %changelog, don't insert a linebreak between your contact detail and the
version-release info. Also, avoid smiley and capitalize your name properly?
- Description should not just copy %{summary}

Package builds fine in mock for F-7

Looks good otherwise

I see that you are looking for someone to sponsor you, and as it happens I'm
allowed to sponsor people. Here is what I would like to do: I see that you've
submitted 3 packages for review, I will review all 3 of them and then after one
or two iterations the can hopefully be approved, assuming that process go well
I'll sponsor you when all 3 are approved, if you agree with this "procedure",
please let me know and I'll start reviewing all 3.

Full review done.

Must Fix:
-libopensync-plugin-syncml.src: W: invalid-license GPL, or as Michel put it:
 License field is wrong. It is LGPL version 2.1 or above, which using the old
 guideline would have been LGPL, and the new license guideline requires you to
 state it as LGPLv2+
-SyncMl in the Summary must be capitalized properly: SyncML
-Description must end with a "."
-drop the ldconfig scripts, this is a plugin not a lib, so they are not needed.

And I forgot one:
-Must have "Requires: libopensync" for %{_libdir}/opensync/plugins and
 %{_libdir}/opensync/formats dir ownership

fresh rebuild
http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-syncml-0.22-4.fc8.i386.rpm
http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-syncml-0.22-4.fc8.src.rpm
http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-syncml.spec

do i need the "Requires libopensync", even if the package requires a file from
libopensync and therefore pulls that in by default? or does this speed up
installing by yum, if i name the packages, instead of letting yum pull in the
required packages by searching for files?

(In reply to comment #8)
> fresh rebuild
>
http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-syncml-0.22-4.fc8.i386.rpm
>
http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-syncml-0.22-4.fc8.src.rpm
> http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-syncml.spec
> 

Looks good, approved!

> do i need the "Requires libopensync", even if the package requires a file from
> libopensync and therefore pulls that in by default?

Ah, I see, although it doesn't require a file, you mean that it requires the
soname (libfoo.so.x) of libopensync, in that case the Requires isn't needed. Its
not a problem either though.

> or does this speed up
> installing by yum, if i name the packages, instead of letting yum pull in the
> required packages by searching for files?

It does speed up yum when replacing a real file requires like:
Requires: /usr/lib/libopensync

As that would require yum to additionally download the filelist database which
contains all filenams for all packages, but here you mean a soname dependency,
which is part of yum's default metadata, so just as fast as a direct package
Requires, also see:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-ee9ab65751a839b02c34f6e23d7b736db293ed89

New Package CVS Request
=======================
Package Name: libopensync-plugin-syncml
Short Description: SyncML plugin for libopensync
Owners: cheese
Branches: devel F-7 F-8
InitialCC: cheese
Cvsextras Commits: yes

New Package CVS Request
=======================
Package Name: libopensync-plugin-syncml
Short Description: SyncML plugin for libopensync
Owners: cheese
Branches: devel F-7 F-8
InitialCC: cheese
Cvsextras Commits: yes

cvs done.

Please push this through the Fedora Updates System after you build it in Koji?
It's not showing up there, so it won't be pushed to the repositories yet.