Bug 245699

Summary: perl-DBD-Sqlite: version 1.13 is available
Product: [Fedora] Fedora Reporter: Ruben Kerkhof <ruben>
Component: perl-DBD-SQLiteAssignee: Stepan Kasal <kasal>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: cweyl, mmaslano, perl-devel, robin.norwood, steve
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.14-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-04-22 06:04:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 411551    
Attachments:
Description Flags
fix dbdimp.c _finalize() -> _reset() none

Description Ruben Kerkhof 2007-06-26 06:15:17 UTC
Description of problem:

version 1.13 of DBD::SQLite is available. Would you please consider upgrading it?
It's a dependency for a new package of mine.

Thanks,

Ruben

Comment 1 Chris Weyl 2007-10-18 04:16:16 UTC
DBD::SQLite >= 1.13 is a prereq of DBIx::Class as well; 1.14 is out.

Any chance of an update to F-7+? :)

Comment 2 Marcela Mašláňová 2007-11-06 15:25:53 UTC
I'll update this package on 1.14 into devel, if no one protests.

Comment 3 Jason Tibbitts 2007-12-20 06:17:48 UTC
It seems that Robin tried to build 1.14 in rawhide a week or so ago but one of
the tests failed.  Also, some of the bugs open against 1.13 and 1.14 are
troubling, such as this report that those versions break Class-DBI:
http://rt.cpan.org/Public/Bug/Display.html?id=21406

Comment 4 Robin Norwood 2007-12-20 19:49:19 UTC
Yeah, he did - then he forgot to come back and fix it.  Given the bugs reported
upstream, how about we just take a pass on 1.13 and 1.14, and see if 1.15 is better?

Comment 5 Ruben Kerkhof 2008-01-15 21:20:46 UTC
Yeah, that's fine with me.

Comment 6 Chris Weyl 2008-03-19 00:48:31 UTC
Going through the DBIx-Class rt queue looking for a fix (sigh) to 1.14 making
t/33storage_reconnect.t fail, I've come across several tickets with patches we
may want to apply (or at least look at), as 1.14 is in rawhide/f9, and 1.15
doesn't seem to be coming along anytime soon.

DBIC
http://rt.cpan.org/Public/Bug/Display.html?id=33308

DBD::SQLite
http://rt.cpan.org/Public/Bug/Display.html?id=33308
http://rt.cpan.org/Ticket/Display.html?id=32100#txn-432936

Basically, it seems to be that just changing sqlite3_finalize() ->
sqlite3_reset() at 2 spots in dbdimp.c resolves many issues.  (Certainly
resolves the test issues I've been having with DBIx::Class.)

I've attached the patch -- I forget the ownership of this module.  Any
objections to my checking these updates into devel and rebuilding?

Comment 7 Chris Weyl 2008-03-19 00:49:54 UTC
Created attachment 298468 [details]
fix dbdimp.c _finalize() -> _reset()

Comment 8 Marcela Mašláňová 2008-03-19 08:16:45 UTC
Looks ok.

Comment 9 Marcela Mašláňová 2008-03-19 08:43:07 UTC
I rebuilt perl-DBD-Sqlite in rawhide. Do you want to tag it for F-9? 

Comment 10 Chris Weyl 2008-03-19 08:46:26 UTC
Taking that as consent :)

Added patch, updated, built:

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=521952

...realized tests were disabled; reenable, test, build:

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=521974


Comment 11 Chris Weyl 2008-03-19 16:12:29 UTC
(In reply to comment #9)
> I rebuilt perl-DBD-Sqlite in rawhide. Do you want to tag it for F-9? 

Definitely -- IMHO this is a fairly important fix, judging by my own experience
and the rt queues :)  It's almost certainly too late to make the beta, but if I
understand the freeze process correctly, we should be OK for F9 GA.


Comment 12 Chris Weyl 2008-03-24 20:18:58 UTC
So, I guess the last bit here before we can close this one out:  should we push
1.14 to F-8 as well?


Comment 13 Fedora Update System 2008-03-25 10:45:07 UTC
perl-DBD-SQLite-1.14-1.fc8 has been submitted as an update for Fedora 8

Comment 14 Fedora Update System 2008-03-26 17:18:11 UTC
perl-DBD-SQLite-1.14-1.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-DBD-SQLite'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-2737

Comment 15 Fedora Update System 2008-04-01 21:33:15 UTC
perl-DBD-SQLite-1.14-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.