SRPM URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class-0.08008-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class.spec Description: This is an SQL to OO mapper with an object API inspired by Class::DBI (and a compatibility layer as a springboard for porting) and a resultset API that allows abstract encapsulation of database operations. It aims to make representing queries in your code as perl- ish as possible while still providing access to as many of the capabilities of the database as possible, including retrieving related records from multiple tables in a single query, JOIN, LEFT JOIN, COUNT, DISTINCT, GROUP BY and HAVING support.
I got Bad build req: No Package Found for perl(DBD::SQLite) >= 1.13. Exiting Can't find 1.13 release but can see 1.12 on koji.
Is perl(DBD::SQLite) built?
From bug 245699, it looks like there are a number of issues with DBD::SQLite == 1.13, 1.14. I'll take a look and see if DBIx::Class _really_ needs 1.14, or if 1.12 will do.
ping?
DBD::SQLite >= 1.13 is definitely needed by the test suite but won't be in Fedora anytime soon (see bug 245699). I've patched Makefile.PL to not insist on 1.13, as well as the test suite to skip those tests which fail under 1.12 (but not 1.13+). I've also patched DBIx::Class::StartupCheck to not complain unless perl is older than 5.8.9 AND the overload bug is present, as (AFAIK) this bug is no longer present in Fedora perl. Additional eyeballs on this are invited and welcome. SRPM URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class-0.08008-2.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class.spec
Also removing bug 245699 (update DBD::SQLite) as a blocker given the patches above,
I think you can still add some more BR to let make test pass like Test::Pod::Coverage http://koji.fedoraproject.org/koji/getfile?taskID=349282&name=build.log Can you please check that and make modification in SPEC? Also, I see rpmlint output as perl-DBIx-Class.src:54: W: unversioned-explicit-provides perl(DBIx::Class::ClassResolver::PassThrough) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible.
Note the new dep on JSON::Any (it was bound to happen sooner or later). SRPM URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class-0.08010-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class.spec
Latest scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=537935
perl-DBIx-Class.src:63: W: unversioned-explicit-provides perl(DBIx::Class::ClassResolver::PassThrough) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-DBIx-Class.src:64: W: unversioned-explicit-provides perl(DBIx::Class::Storage::TxnScopeGuard) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-DBIx-Class.src: W: patch-not-applied Patch1: skip_sqlite_1_13_tests.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong.
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=543385 SRPM URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class-0.08010-4.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class.spec Note there are a number of optional tests skipping -- these all run and pass for me on F-8 (with SQL::Translator updated to 0.09000). They're testing the Class::DBI compatibility layer, not core functionality.
any reason (SQL::Translator 0.09000)tests are skipping for -devel build then. I see t/03podcoverage............................skipped all skipped: set TEST_POD to enable this test t/86sqlt...................................skipped all skipped: SQL::Translator required t/94versioning.............................skipped all skipped: needs DBD::SQLite and SQL::Translator 0.09 for testing t/bindtype_columns.........................skipped all skipped: Set $ENV{DBICTEST_PG_DSN}, _USER and _PASS to run this test
(In reply to comment #13) > any reason (SQL::Translator 0.09000)tests are skipping for -devel build then. I see > t/03podcoverage............................skipped > all skipped: set TEST_POD to enable this test POD coverage tests currently "fail", so this needs to be disabled. Noted in the updated spec below (release 5). > t/86sqlt...................................skipped > all skipped: SQL::Translator required > > t/94versioning.............................skipped > all skipped: needs DBD::SQLite and SQL::Translator 0.09 for testing These two tests (including the optional CDBI-compat tests, apparently) depend on an undocumented prereq of Class::Data::Inheritable -- added as a BR. > t/bindtype_columns.........................skipped > all skipped: Set $ENV{DBICTEST_PG_DSN}, _USER and _PASS to run this test This optional test requires a live postgresql database to test against; not available in the buildsystem. http://koji.fedoraproject.org/koji/taskinfo?taskID=560545 SRPM URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class-0.08010-5.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class.spec
ping? Is there anything you see needing to be updated to move this review forward? :)
Review: + package builds in mock. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=640082 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 5b7eee3c1ddf6f865c816cde9e9bdf62 DBIx-Class-0.08010.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful (7 subtests UNEXPECTEDLY SUCCEEDED), 15 tests and 18 subtests skipped. Passed TODO Stat Wstat TODOs Pass List of Passed ------------------------------------------------------------------------------- t/81transactions.t 13 7 55 59 61-65 Files=106, Tests=2568, 48 wallclock secs (39.58 cusr + 4.35 csys = 43.93 CPU) APPROVED.
New Package CVS Request ======================= Package Name: perl-DBIx-Class Short Description: Extensible and flexible object <-> relational mapper Owners: cweyl Branches: F-8, F-9, devel InitialCC: perl-sig
cvs done.
Imported and build in devel. Thanks for the review! :)
Package Change Request ====================== Package Name: perl-DBIx-Class New Branches: el6 Owners: iarnell tremble
Git done (by process-git-requests).