Bug 2464801
| Summary: | Review Request: pi-coding-agent - An open source coding agent | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom.Rix |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ai-packagers-sig, gordon.messmer, package-review, pbrobinson |
| Target Milestone: | --- | Flags: | Tom.Rix:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://github.com/earendil-works/pi | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom.Rix
2026-05-03 21:11:24 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. How to use pi-coding agent is written up here. https://fedoraproject.org/wiki/SIGs/AI-ML#pi-coding-agent Spec URL: https://trix.fedorapeople.org/pi-coding-agent.spec SRPM URL: https://trix.fedorapeople.org/pi-coding-agent-0.78.1-1.fc45.src.rpm Upstream location changed, this is the latest. Copr build: https://copr.fedorainfracloud.org/coprs/build/10569915 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2464801-pi-coding-agent/fedora-rawhide-x86_64/10569915-pi-coding-agent/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://trix.fedorapeople.org/pi-coding-agent.spec SRPM URL: https://trix.fedorapeople.org/pi-coding-agent-0.79.4-1.fc45.src.rpm Updated to latest. At least two rpmlint reports should be addressed:
Number 1:
The node modules bundle contains pre-built binaries. I believe this will require that the package dist-git includes a script that fetches the node_modules, strips them of binaries, and archives the result.
pi-coding-agent.noarch: W: only-non-binary-in-usr-lib
$ file node_modules_prod/@earendil-works/pi-tui/native/*/*/*/*
node_modules_prod/@earendil-works/pi-tui/native/darwin/prebuilds/darwin-arm64/darwin-modifiers.node: Mach-O 64-bit arm64 bundle, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL>
node_modules_prod/@earendil-works/pi-tui/native/darwin/prebuilds/darwin-x64/darwin-modifiers.node: Mach-O 64-bit x86_64 bundle, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL>
node_modules_prod/@earendil-works/pi-tui/native/win32/prebuilds/win32-arm64/win32-console-mode.node: PE32+ executable for MS Windows 6.02 (DLL), ARM64, 3 sections
node_modules_prod/@earendil-works/pi-tui/native/win32/prebuilds/win32-x64/win32-console-mode.node: PE32+ executable for MS Windows 6.00 (DLL), x86-64, 3 sections
Number 2:
pi-coding-agent.spec: W: no-%check-section
The project site indicates that a test suite exists: "./test.sh # Run tests (skips LLM-dependent tests without API keys)".
That should be run in the %check section. If that's not possible, the package should at least document why it isn't possible.
...wasm needs to be stripped, as well: node_modules_prod/@silvia-odwyer/photon-node/photon_rs_bg.wasm Spec URL: https://trix.fedorapeople.org/pi-coding-agent.spec SRPM URL: https://trix.fedorapeople.org/pi-coding-agent-0.79.9-1.fc45.src.rpm > file node_modules_prod/@earendil-works/pi-tui/native/*/*/*/* > ...wasm needs to be stripped, as well: # remove some binaries rm -rf node_modules_prod/@earendil-works/pi-tui/native rm -f node_modules_prod/@silvia-odwyer/photon-node/photon_rs_bg.wasm > The project site indicates that a test suite exists: "./test.sh Trying, shows immediate failure needing vitest. https://www.npmjs.com/package/vitest installing vitest during the build would not be possible. ./test.sh Moved auth.json to backup Running tests without API keys... > pi-monorepo.3 test > npm run test --workspaces --if-present > @earendil-works/pi-agent-core.9 test > vitest --run sh: line 1: vitest: command not found Copr build: https://copr.fedorainfracloud.org/coprs/build/10620674 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2464801-pi-coding-agent/fedora-rawhide-x86_64/10620674-pi-coding-agent/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |