Bug 246903
| Summary: | Initscript Review | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Harald Hoyer <harald> | ||||||
| Component: | ddclient | Assignee: | Robert Scheck <redhat-bugzilla> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | rawhide | CC: | jrowens.fedora, redhat-bugzilla, thomas | ||||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | ddclient-3.8.0-2.el5 | Doc Type: | Enhancement | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2010-05-29 11:07:56 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 246824 | ||||||||
| Attachments: |
|
||||||||
|
Description
Harald Hoyer
2007-07-05 13:49:04 UTC
Changing version to '9' as part of upcoming Fedora 9 GA. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping This message is a reminder that Fedora 9 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 9. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '9'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 9's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 9 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Moving forward as this report is still valid. Created attachment 357557 [details]
initscript which might comply with the LSB
I think the attached initscript should meet the LSB requirements, although I'm not too sure about the exit statuses, if someone could check those out. I think they're pretty much handled by /etc/rc.d/init.d/functions, and I assume it knows what it's doing. I suppose given that the script is a Source2 instead of part of the tarball or a cat << EOF in the spec, it's easier to just attach the whole script here, but in case it's wanted, the patch is small enough to reasonably fit in here; just remember to fix wrapped lines, should just be the usage at the end:
--- ddclient.initscript.orig 2007-03-03 01:36:48.000000000 -0700
+++ ddclient.initscript 2009-08-15 18:11:58.000000000 -0700
@@ -1,4 +1,14 @@
#!/bin/sh
+### BEGIN INIT INFO
+# Provides: ddclient
+# Required-Start: $syslog $local_fs $network
+# Should-Start: $named
+# Required-Stop: $syslog $local_fs $network
+# Default-Stop: 0 1 2 3 4 5 6
+# Short-Description: shell script to start and stop ddclient.
+# Description:ddclient is a Perl client used to update dynamic DNS
+# entries for accounts on many dynamic DNS services
+### END INIT INFO
#
# ddclient This shell script takes care of starting and stopping ddclient.
#
@@ -52,28 +62,29 @@
}
reload() {
- restart
-}
-
-force_reload() {
- restart
+ echo -n $"Reloading $prog: "
+ # reload won't be called during update, so go ahead and use -p $pid
+ killproc -p $pid
+ retval=$?
+ echo
+ return $retval
}
# See how we were called.
case "$1" in
- start|stop|restart|reload)
+ start|stop|restart)
$1
;;
- force-reload)
- force_reload
+ reload|force-reload)
+ reload
;;
status)
status -p $pid $prog
;;
try-restart|condrestart)
- [ ! -f $lockfile ] || restart
+ [ -f $lockfile ] && restart
;;
*)
- echo $"Usage: $0 {start|stop|status|restart|try-restart|reload|force-reload}"
+ echo $"Usage: $0 {start|stop|status|restart|try-restart|condrestart|reload|force-reload}"
exit 2
esac
Oh! Besides the fact that it did wrap that second line after END INIT INFO after all, that space which is the second character of the second line of the Description: is supposed to be a tab, but two or more spaces would do just as well. That's pretty much a must. Created attachment 357558 [details]
Fixed up initscript
Grr... and I missed a space after the colon, and switched the punctuation around.... Might as well just use the updated attachment here, and consider the patch above a rough guide to what's been changed.
I'm trying to get this worked into the update from 3.7.3 to 3.8.0, over in Bug 551906, now. We still need to change this initscript to not interference with bug #506286. Directly after "start() {", the following is required as one line [ ! -f /var/lock/subsys/network -a ! -f /var/lock/subsys/NetworkManager ] && exit 0 Already working on that as the package owner seems to be AWOL. I've done as much as I can; I don't have the CVS access, or whatever exactly is needed to take it from here. If you can commit, more power to you! ddclient-3.8.0-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc13 ddclient-3.8.0-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc12 ddclient-3.8.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc11 ddclient-3.8.0-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.el5 ddclient-3.8.0-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.el4 ddclient-3.8.0-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc13 ddclient-3.8.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc11 ddclient-3.8.0-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.el5 ddclient-3.8.0-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc12 ddclient-3.8.0-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.el4 ddclient-3.8.0-1.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ddclient'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.el4 ddclient-3.8.0-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ddclient'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.el5 ddclient-3.8.0-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ddclient'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc12 ddclient-3.8.0-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ddclient'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc11 ddclient-3.8.0-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ddclient'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ddclient-3.8.0-1.fc13 This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. ddclient-3.8.0-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ddclient-3.8.0-2.fc13 ddclient-3.8.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ddclient-3.8.0-2.fc12 ddclient-3.8.0-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/ddclient-3.8.0-2.fc11 ddclient-3.8.0-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/ddclient-3.8.0-2.el5 ddclient-3.8.0-2.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/ddclient-3.8.0-2.el4 Fixed with ddclient-3.8.0-2. ddclient-3.8.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. ddclient-3.8.0-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. ddclient-3.8.0-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. ddclient-3.8.0-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. ddclient-3.8.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |