Bug 246991

Summary: Initscript Review
Product: [Fedora] Fedora Reporter: Harald Hoyer <harald>
Component: nasAssignee: Frank Büttner <bugzilla>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-08-26 07:02:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 246824    
Attachments:
Description Flags
The new init file
none
now with an LSB header none

Description Harald Hoyer 2007-07-05 13:54:32 UTC
Please have a look at the wikipage 
http://fedoraproject.org/wiki/FCNewInit/Initscripts
and change your initscripts to comply with the LSB standard.
Especially check the exit status and add a LSB Header.
E.g. starting a service should return with 0, if the service is already running and stopping a stopped service should also return with 0.

Also check, if your service has to be _on_ per default, and turn it off in the old chkconfig line, if not.

Thank you.

Comment 1 Frank Büttner 2007-08-04 20:06:39 UTC
Created attachment 160698 [details]
The new init file

Comment 2 Frank Büttner 2007-08-04 20:07:26 UTC
Can you check it?
Yes it will be started by default.

Comment 3 Harald Hoyer 2007-08-06 09:23:33 UTC
hmm, no LSB Header... otherwise, ok

Comment 4 Frank Büttner 2007-08-11 17:47:45 UTC
Created attachment 161118 [details]
now with an LSB header

Comment 5 Frank Büttner 2007-08-11 17:48:36 UTC
Is this now correct?

Comment 6 Harald Hoyer 2007-08-19 07:38:16 UTC
looks better :-)

Comment 7 Frank Büttner 2007-08-19 08:07:46 UTC
Can I mark it as resolved?
Do you know an automatic tool for verify init scripts?

Comment 8 Harald Hoyer 2007-08-20 07:59:23 UTC
yes, and no..

Comment 9 Frank Büttner 2007-08-26 06:57:52 UTC
ok, so I close it.