Bug 246991 - Initscript Review
Summary: Initscript Review
Alias: None
Product: Fedora
Classification: Fedora
Component: nas
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Frank Büttner
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: InitscriptStatus
TreeView+ depends on / blocked
Reported: 2007-07-05 13:54 UTC by Harald Hoyer
Modified: 2007-11-30 22:12 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-08-26 07:02:33 UTC

Attachments (Terms of Use)
The new init file (1.25 KB, text/plain)
2007-08-04 20:06 UTC, Frank Büttner
no flags Details
now with an LSB header (1.38 KB, text/plain)
2007-08-11 17:47 UTC, Frank Büttner
no flags Details

Description Harald Hoyer 2007-07-05 13:54:32 UTC
Please have a look at the wikipage 
and change your initscripts to comply with the LSB standard.
Especially check the exit status and add a LSB Header.
E.g. starting a service should return with 0, if the service is already running and stopping a stopped service should also return with 0.

Also check, if your service has to be _on_ per default, and turn it off in the old chkconfig line, if not.

Thank you.

Comment 1 Frank Büttner 2007-08-04 20:06:39 UTC
Created attachment 160698 [details]
The new init file

Comment 2 Frank Büttner 2007-08-04 20:07:26 UTC
Can you check it?
Yes it will be started by default.

Comment 3 Harald Hoyer 2007-08-06 09:23:33 UTC
hmm, no LSB Header... otherwise, ok

Comment 4 Frank Büttner 2007-08-11 17:47:45 UTC
Created attachment 161118 [details]
now with an LSB header

Comment 5 Frank Büttner 2007-08-11 17:48:36 UTC
Is this now correct?

Comment 6 Harald Hoyer 2007-08-19 07:38:16 UTC
looks better :-)

Comment 7 Frank Büttner 2007-08-19 08:07:46 UTC
Can I mark it as resolved?
Do you know an automatic tool for verify init scripts?

Comment 8 Harald Hoyer 2007-08-20 07:59:23 UTC
yes, and no..

Comment 9 Frank Büttner 2007-08-26 06:57:52 UTC
ok, so I close it.

Note You need to log in before you can comment on or make changes to this bug.