Bug 247312

Summary:	Review Request: MyPasswordSafe - A graphical password management tool
Product:	[Fedora] Fedora	Reporter:	Ralf Ertzinger <redhat-bugzilla>
Component:	Package Review	Assignee:	Warren Togami <wtogami>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	wtogami: fedora-review+ wtogami: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-08-02 19:53:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ralf Ertzinger 2007-07-06 20:18:52 UTC

Spec URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe.spec
SRPM URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe-0.6.7-0.1.20061216.sky.src.rpm
Description:
MyPasswordSafe is a straight-forward, easy-to-use password manager that
maintains compatibility with Password Safe files. MyPasswordSafe has the
following features:

* Safes are encrypted when they are stored to disk.
* Passwords never have to be seen, because they are copied to the clipboard
* Random passwords can be generated.
* Window size, position, and column widths are remembered.
* Passwords remain encrypted until they need to be decrypted at the dialog
  and file levels.
* A safe can be made active so it will always be opened when MyPasswordSafe
  starts.
* Supports Unicode in the safes
* Languages supported: English and French

Comment 1 Warren Togami 2007-07-18 20:42:10 UTC

- %changelog
- 0.6.7-0.1.20061216.fc8
There is no need to write the %dist tag here.  It is misleading.

+ make -j3 PREFIX=/usr
echo "#ifndef CONFIG_H" > src/config.h
qmake -o MyPasswordSafe.mak MyPasswordSafe.pro
make: qmake: Command not found
make: *** [MyPasswordSafe.mak] Error 127
make: *** Waiting for unfinished jobs....
echo "#define CONFIG_H" >> src/config.h
echo "#define PREFIX \"/usr\"" >> src/config.h
echo "#define VERSION \"0.6.7\"" >> src/config.h
echo "#define COMP_DATE \"20070718\"" >> src/config.h
echo "#define COMP_USER \"builder1\"" >> src/config.h
echo "#define COMP_HOST \"newcaprica\"" >> src/config.h
echo "#endif" >> src/config.h
error: Bad exit status from /var/tmp/rpm-tmp.22443 (%build)

Manual build attempt on F7.  Some missing buildrequire?

Comment 2 Ralf Ertzinger 2007-07-18 21:00:38 UTC

Dist tag will be removed.

qmake comes from qt-devel (which is in BR). Local path issue?

Package builds in koji for F-7:
http://koji.fedoraproject.org/scratch/ertzing/task_70007/

Comment 3 Warren Togami 2007-07-18 21:34:41 UTC

unset QTDIR || : ; . /etc/profile.d/qt.sh

Add this near the top of your %build section.  This is the standard for all
qt-using packages.

Comment 4 Ralf Ertzinger 2007-07-19 20:50:01 UTC

Spec URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe.spec
SRPM URL:
http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe-0.6.7-0.2.20061216.sky.src.rpm

Fixes QT environment
Fixes dist-in-changelog

Comment 5 Warren Togami 2007-07-24 17:49:01 UTC

error 404

Comment 6 Ralf Ertzinger 2007-07-24 19:31:55 UTC

Fixed.

Comment 7 Warren Togami 2007-07-27 20:29:00 UTC

unset QTDIR || :

This isn't incorrect, but curious as to how this could ever fail to necessitate
the || :?

Package looks good.  

APPROVED

Comment 8 Ralf Ertzinger 2007-08-01 20:52:59 UTC

New Package CVS Request
=======================
Package Name: MyPasswordSafe
Short Description: A graphical password management tool
Owners: redhat-bugzilla
Branches: F-7
InitialCC:

Comment 9 Ralf Ertzinger 2007-08-02 19:53:36 UTC

Thanks for the review.