Red Hat Bugzilla – Bug 247312
Review Request: MyPasswordSafe - A graphical password management tool
Last modified: 2007-11-30 17:12:09 EST
Spec URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe.spec SRPM URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe-0.6.7-0.1.20061216.sky.src.rpm Description: MyPasswordSafe is a straight-forward, easy-to-use password manager that maintains compatibility with Password Safe files. MyPasswordSafe has the following features: * Safes are encrypted when they are stored to disk. * Passwords never have to be seen, because they are copied to the clipboard * Random passwords can be generated. * Window size, position, and column widths are remembered. * Passwords remain encrypted until they need to be decrypted at the dialog and file levels. * A safe can be made active so it will always be opened when MyPasswordSafe starts. * Supports Unicode in the safes * Languages supported: English and French
- %changelog - 0.6.7-0.1.20061216.fc8 There is no need to write the %dist tag here. It is misleading. + make -j3 PREFIX=/usr echo "#ifndef CONFIG_H" > src/config.h qmake -o MyPasswordSafe.mak MyPasswordSafe.pro make: qmake: Command not found make: *** [MyPasswordSafe.mak] Error 127 make: *** Waiting for unfinished jobs.... echo "#define CONFIG_H" >> src/config.h echo "#define PREFIX \"/usr\"" >> src/config.h echo "#define VERSION \"0.6.7\"" >> src/config.h echo "#define COMP_DATE \"20070718\"" >> src/config.h echo "#define COMP_USER \"builder1\"" >> src/config.h echo "#define COMP_HOST \"newcaprica\"" >> src/config.h echo "#endif" >> src/config.h error: Bad exit status from /var/tmp/rpm-tmp.22443 (%build) Manual build attempt on F7. Some missing buildrequire?
Dist tag will be removed. qmake comes from qt-devel (which is in BR). Local path issue? Package builds in koji for F-7: http://koji.fedoraproject.org/scratch/ertzing/task_70007/
unset QTDIR || : ; . /etc/profile.d/qt.sh Add this near the top of your %build section. This is the standard for all qt-using packages.
Spec URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe.spec SRPM URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe-0.6.7-0.2.20061216.sky.src.rpm Fixes QT environment Fixes dist-in-changelog
error 404
Fixed.
unset QTDIR || : This isn't incorrect, but curious as to how this could ever fail to necessitate the || :? Package looks good. APPROVED
New Package CVS Request ======================= Package Name: MyPasswordSafe Short Description: A graphical password management tool Owners: redhat-bugzilla@camperquake.de Branches: F-7 InitialCC:
Thanks for the review.