Bug 247312 - Review Request: MyPasswordSafe - A graphical password management tool
Summary: Review Request: MyPasswordSafe - A graphical password management tool
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Warren Togami
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-07-06 20:18 UTC by Ralf Ertzinger
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-08-02 19:53:36 UTC
Type: ---
Embargoed:
wtogami: fedora-review+
wtogami: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Ertzinger 2007-07-06 20:18:52 UTC
Spec URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe.spec
SRPM URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe-0.6.7-0.1.20061216.sky.src.rpm
Description:
MyPasswordSafe is a straight-forward, easy-to-use password manager that
maintains compatibility with Password Safe files. MyPasswordSafe has the
following features:

* Safes are encrypted when they are stored to disk.
* Passwords never have to be seen, because they are copied to the clipboard
* Random passwords can be generated.
* Window size, position, and column widths are remembered.
* Passwords remain encrypted until they need to be decrypted at the dialog
  and file levels.
* A safe can be made active so it will always be opened when MyPasswordSafe
  starts.
* Supports Unicode in the safes
* Languages supported: English and French

Comment 1 Warren Togami 2007-07-18 20:42:10 UTC
- %changelog
- 0.6.7-0.1.20061216.fc8
There is no need to write the %dist tag here.  It is misleading.

+ make -j3 PREFIX=/usr
echo "#ifndef CONFIG_H" > src/config.h
qmake -o MyPasswordSafe.mak MyPasswordSafe.pro
make: qmake: Command not found
make: *** [MyPasswordSafe.mak] Error 127
make: *** Waiting for unfinished jobs....
echo "#define CONFIG_H" >> src/config.h
echo "#define PREFIX \"/usr\"" >> src/config.h
echo "#define VERSION \"0.6.7\"" >> src/config.h
echo "#define COMP_DATE \"20070718\"" >> src/config.h
echo "#define COMP_USER \"builder1\"" >> src/config.h
echo "#define COMP_HOST \"newcaprica\"" >> src/config.h
echo "#endif" >> src/config.h
error: Bad exit status from /var/tmp/rpm-tmp.22443 (%build)

Manual build attempt on F7.  Some missing buildrequire?

Comment 2 Ralf Ertzinger 2007-07-18 21:00:38 UTC
Dist tag will be removed.

qmake comes from qt-devel (which is in BR). Local path issue?

Package builds in koji for F-7:
http://koji.fedoraproject.org/scratch/ertzing/task_70007/

Comment 3 Warren Togami 2007-07-18 21:34:41 UTC
unset QTDIR || : ; . /etc/profile.d/qt.sh

Add this near the top of your %build section.  This is the standard for all
qt-using packages.



Comment 4 Ralf Ertzinger 2007-07-19 20:50:01 UTC
Spec URL: http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe.spec
SRPM URL:
http://www.skytale.net/files/MyPasswordSafe/MyPasswordSafe-0.6.7-0.2.20061216.sky.src.rpm

Fixes QT environment
Fixes dist-in-changelog

Comment 5 Warren Togami 2007-07-24 17:49:01 UTC
error 404

Comment 6 Ralf Ertzinger 2007-07-24 19:31:55 UTC
Fixed.

Comment 7 Warren Togami 2007-07-27 20:29:00 UTC
unset QTDIR || :

This isn't incorrect, but curious as to how this could ever fail to necessitate
the || :?

Package looks good.  

APPROVED

Comment 8 Ralf Ertzinger 2007-08-01 20:52:59 UTC
New Package CVS Request
=======================
Package Name: MyPasswordSafe
Short Description: A graphical password management tool
Owners: redhat-bugzilla
Branches: F-7
InitialCC: 

Comment 9 Ralf Ertzinger 2007-08-02 19:53:36 UTC
Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.