Bug 2487230

Summary: Review Request: rust-hax-lib-macros - Hax-specific proc-macros for Rust programs
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: code, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/hax-lib-macros
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2487317    

Description Dominik 'Rathann' Mierzejewski 2026-06-09 18:16:40 UTC
Spec URL: https://rathann.fedorapeople.org/review/rust-hax-lib-macros/rust-hax-lib-macros.spec
SRPM URL: https://rathann.fedorapeople.org/review/rust-hax-lib-macros/rust-hax-lib-macros-0.3.7-1.fc45.src.rpm
Description:
Hax-specific proc-macros for Rust programs.

This crate defines proc macros to be used in Rust programs that are extracted with hax. It provides proc macros such as requires and ensures to define pre- and post-conditions for functions.

Fedora Account System Username: rathann

Comment 1 Fedora Review Service 2026-06-09 18:20:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10584061
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2487230-rust-hax-lib-macros/fedora-rawhide-x86_64/10584061-rust-hax-lib-macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2026-06-13 07:36:57 UTC
> # FIXME: no license files detected

You have to fix this. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text, and see https://src.fedoraproject.org/rpms/rust-purl/blob/rawhide/f/rust2rpm.toml for an example.

Normally, I would go ahead and open an upstream PR similar to https://github.com/phylum-dev/purl/pull/33, but it’s kind of tedious to find all the published-on-crates.io crates in the upstream repo, so I’ll leave that to you.