Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://rathann.fedorapeople.org/review/rust-hax-lib-macros/rust-hax-lib-macros.spec SRPM URL: https://rathann.fedorapeople.org/review/rust-hax-lib-macros/rust-hax-lib-macros-0.3.7-1.fc45.src.rpm Description: Hax-specific proc-macros for Rust programs. This crate defines proc macros to be used in Rust programs that are extracted with hax. It provides proc macros such as requires and ensures to define pre- and post-conditions for functions. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/10584061 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2487230-rust-hax-lib-macros/fedora-rawhide-x86_64/10584061-rust-hax-lib-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> # FIXME: no license files detected You have to fix this. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text, and see https://src.fedoraproject.org/rpms/rust-purl/blob/rawhide/f/rust2rpm.toml for an example. Normally, I would go ahead and open an upstream PR similar to https://github.com/phylum-dev/purl/pull/33, but it’s kind of tedious to find all the published-on-crates.io crates in the upstream repo, so I’ll leave that to you.
Spec URL: https://rathann.fedorapeople.org/review/rust-hax-lib-macros/rust-hax-lib-macros.spec SRPM URL: https://rathann.fedorapeople.org/review/rust-hax-lib-macros/rust-hax-lib-macros-0.3.7-2.fc45.src.rpm Fixed.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10781764 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2487230-rust-hax-lib-macros/fedora-rawhide-x86_64/10781764-rust-hax-lib-macros/fedora-review/review.txt Found issues: - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build] Now fixed correctly.
Created attachment 2152881 [details] The .spec file difference from Copr build 10781764 to 10784331
Copr build: https://copr.fedorainfracloud.org/coprs/build/10784331 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2487230-rust-hax-lib-macros/fedora-rawhide-x86_64/10784331-rust-hax-lib-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The package is APPROVED, as the license issue has been handled correctly and I found no other issues, but upstream should have been notified of the problem and ideally offered a fix. I opened https://github.com/cryspen/hax/pull/2106 for this purpose; please add a link to that PR in the comment above Source10 when you import the package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/hax-lib- macros-0.3.7/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem; due to reasonable rust2rpm design decisions - While the missing license file has been correctly (and necessarily) fixed, upstream should have been notified about the problem and ideally offered a fix. I opened https://github.com/cryspen/hax/pull/2106 for this purpose; please add a link to that PR in the comment above Source10. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0". 15 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/20260731/2487230-rust-hax-lib- macros/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- hax-lib-macros-devel , rust-hax-lib-macros+default-devel [x]: Package functions as described. Tests are correctly build and executed, even if there are zero tests we can actually run. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. License file from the correct release tag in the upstream repository is necessarily and appropriately patched in. However, upstream should have been encouraged to fix the problem in future releases. See https://github.com/cryspen/hax/pull/2106. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Missing license file should have been reported upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=148516276 [x]: %check is present and all tests pass. Tests are correctly build and executed, even if there are zero tests we can actually run. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK: Differences are solely due to rpmautospec macro expansion [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: rust-hax-lib-macros-devel-0.3.7-2.fc45.noarch.rpm rust-hax-lib-macros+default-devel-0.3.7-2.fc45.noarch.rpm rust-hax-lib-macros-0.3.7-2.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfe4fx8sa')] checks: 32, packages: 3 rust-hax-lib-macros+default-devel.noarch: E: spelling-error ('proc', 'Summary(en_US) proc -> crop, prov, pro') rust-hax-lib-macros+default-devel.noarch: E: spelling-error ('proc', '%description -l en_US proc -> crop, prov, pro') rust-hax-lib-macros.src: E: spelling-error ('proc', 'Summary(en_US) proc -> crop, prov, pro') rust-hax-lib-macros.src: E: spelling-error ('proc', '%description -l en_US proc -> crop, prov, pro') rust-hax-lib-macros-devel.noarch: E: spelling-error ('proc', 'Summary(en_US) proc -> crop, prov, pro') rust-hax-lib-macros-devel.noarch: E: spelling-error ('proc', '%description -l en_US proc -> crop, prov, pro') 3 packages and 0 specfiles checked; 6 errors, 0 warnings, 13 filtered, 6 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 rust-hax-lib-macros+default-devel.noarch: E: spelling-error ('proc', 'Summary(en_US) proc -> crop, prov, pro') rust-hax-lib-macros+default-devel.noarch: E: spelling-error ('proc', '%description -l en_US proc -> crop, prov, pro') rust-hax-lib-macros-devel.noarch: E: spelling-error ('proc', 'Summary(en_US) proc -> crop, prov, pro') rust-hax-lib-macros-devel.noarch: E: spelling-error ('proc', '%description -l en_US proc -> crop, prov, pro') 2 packages and 0 specfiles checked; 4 errors, 0 warnings, 9 filtered, 4 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/hax-lib-macros/0.3.7/download#/hax-lib-macros-0.3.7.crate : CHECKSUM(SHA256) this package : 28da835a5f153e9f3d0cc1f42ee605a1cfa9093c93348193793d60a1b0908b51 CHECKSUM(SHA256) upstream package : 28da835a5f153e9f3d0cc1f42ee605a1cfa9093c93348193793d60a1b0908b51 https://github.com/cryspen/hax/raw/refs/tags/hax-lib-macros-v0.3.7/LICENSE : CHECKSUM(SHA256) this package : 9a50bad5a51e0ad726ea3a7f4b7b758e1b4d1784e6abefe1367f5bf01e972725 CHECKSUM(SHA256) upstream package : 9a50bad5a51e0ad726ea3a7f4b7b758e1b4d1784e6abefe1367f5bf01e972725 Requires -------- rust-hax-lib-macros-devel (rpmlib, GLIBC filtered): (crate(proc-macro2/default) >= 1.0.66 with crate(proc-macro2/default) < 2.0.0~) (crate(quote/default) >= 1.0.32 with crate(quote/default) < 2.0.0~) (crate(syn/default) >= 2.0.0 with crate(syn/default) < 3.0.0~) (crate(syn/full) >= 2.0.0 with crate(syn/full) < 3.0.0~) (crate(syn/visit) >= 2.0.0 with crate(syn/visit) < 3.0.0~) (crate(syn/visit-mut) >= 2.0.0 with crate(syn/visit-mut) < 3.0.0~) cargo rust-hax-lib-macros+default-devel (rpmlib, GLIBC filtered): cargo crate(hax-lib-macros) Provides -------- rust-hax-lib-macros-devel: crate(hax-lib-macros) purl(pkg:cargo/hax-lib-macros.7) rust-hax-lib-macros-devel rust-hax-lib-macros+default-devel: crate(hax-lib-macros/default) rust-hax-lib-macros+default-devel Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/20260731/2487230-rust-hax-lib-macros/srpm/rust-hax-lib-macros.spec 2026-07-31 14:11:52.238045815 +0100 +++ /home/ben/fedora/review/20260731/2487230-rust-hax-lib-macros/srpm-unpacked/rust-hax-lib-macros.spec 2026-07-28 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 2; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 28 %bcond check 1 @@ -71,3 +81,9 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Tue Jul 28 2026 Dominik 'Rathann' Mierzejewski <dominik> - 0.3.7-2 +- include LICENSE + +* Mon Jul 27 2026 Dominik 'Rathann' Mierzejewski <dominik> - 0.3.7-1 +- initial package +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2487230 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, SugarActivity, fonts, Java, PHP, Python, Haskell, Ocaml, Perl, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hax-lib-macros Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-b6ef0b1a49 (rust-hax-lib-macros-0.3.7-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-b6ef0b1a49
FEDORA-2026-b6ef0b1a49 (rust-hax-lib-macros-0.3.7-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.