Bug 2488745
| Summary: | Review Request: kf6-oxygen-icons - Oxygen icon theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://invent.kde.org/frameworks/oxygen-icons | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-07-04 21:43:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Steve Cossette
2026-06-14 12:04:26 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm Changed binary package name Taking this review. There's a few things missing here: * The description for oxygen-icon-theme is empty. * The file trigger scriptlets for the icon theme are missing (you can see an example of this in the kf6-breeze-icons spec) * Missing ghost file for the icon theme cache file (cf kf6-breeze-icons spec for this) * To conserve space, it's probably a good idea to hardlink files like the breeze theme spec does Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm Fixed subpackage summary Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm Fixed scriptlets/hardlinking > # %%ghost icon.cache
> touch %{buildroot}%{_kf6_datadir}/icons/oxygen/icon-theme.cache
This needs a ghost entry in the file list. A more granular file list is required here...
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm Made the %files section more granular Review notes: * Package follows Fedora packaging guidelines * Package licensing is correct and license data is installed properly * Package builds and installs * No serious issues from rpmlint PACKAGE APPROVED. Thank you for the review, Neal The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-oxygen-icons Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` |