Bug 2488745 - Review Request: kf6-oxygen-icons - Oxygen icon theme
Summary: Review Request: kf6-oxygen-icons - Oxygen icon theme
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/frameworks/oxy...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-06-14 12:04 UTC by Steve Cossette
Modified: 2026-07-04 21:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-07-04 21:43:54 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Steve Cossette 2026-06-14 12:04:26 UTC 
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm

Description:
Oxygen Icons is a freedesktop.org compatible icon theme originally
developed for the KDE Plasma desktop environment in combination with
the Oxygen Style. It features smooth gradients, soft shadows, and a
slightly glossy look.

Fedora Account System Username: farchord
Comment 1 Steve Cossette 2026-06-14 19:55:15 UTC 
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm

Changed binary package name
Comment 2 Neal Gompa 2026-06-15 02:54:05 UTC 
Taking this review.
Comment 3 Neal Gompa 2026-06-15 02:58:12 UTC 
There's a few things missing here:

* The description for oxygen-icon-theme is empty.
* The file trigger scriptlets for the icon theme are missing (you can see an example of this in the kf6-breeze-icons spec)
* Missing ghost file for the icon theme cache file (cf kf6-breeze-icons spec for this)
* To conserve space, it's probably a good idea to hardlink files like the breeze theme spec does
Comment 4 Steve Cossette 2026-06-15 10:08:25 UTC 
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm

Fixed subpackage summary
Comment 5 Steve Cossette 2026-06-15 10:18:28 UTC 
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm

Fixed scriptlets/hardlinking
Comment 6 Neal Gompa 2026-06-16 07:10:20 UTC 
> # %%ghost icon.cache
> touch %{buildroot}%{_kf6_datadir}/icons/oxygen/icon-theme.cache

This needs a ghost entry in the file list. A more granular file list is required here...
Comment 7 Steve Cossette 2026-06-18 13:36:50 UTC 
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-oxygen-icons/kf6-oxygen-icons-6.27.0-1.fc44.src.rpm

Made the %files section more granular
Comment 8 Neal Gompa 2026-06-18 13:39:16 UTC 
Review notes:

* Package follows Fedora packaging guidelines
* Package licensing is correct and license data is installed properly
* Package builds and installs
* No serious issues from rpmlint

PACKAGE APPROVED.
Comment 9 Steve Cossette 2026-06-18 13:43:48 UTC 
Thank you for the review, Neal
Comment 10 Fedora Admin user for bugzilla script actions 2026-06-18 13:43:54 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-oxygen-icons
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Note You need to log in before you can comment on or make changes to this bug.