Bug 2489112

The dependencies for this (including compat packages, since default features include both v56 and v57) are now in Rawhide. Until they appear in a daily Rawhide compose, this can be reviewed with:

 fedora-review -b 2489112 --mock-options=--enablerepo=local

There’s now a new version 0.39.0 available, which *also* needs a v60 feature. I’m waiting for rust-rustdoc-types0.57 and rust-trustfall-rustdoc-adapter57 compat packages. Then rust-cargo-semver-checks, bug 2489166, would need to be patched for 0.39. I would suggest that (if someone has time) the package review can still go ahead with 0.38.0 since the upstream changes for 0.39.0[1] are rather straightforward.

[1] https://github.com/obi1kenobi/trustfall-rustdoc/compare/v0.38.0...v0.39.0

So the latest release is now 0.41, but the very latest rust-cargo-semver-checks now depends on 0.39; see https://github.com/obi1kenobi/trustfall-rustdoc/compare/v0.39.0...v0.41.0. I’ll therefore update this submission to 0.39.0 and then update the rust-cargo-semver-checks submission to match.

New Spec URL: https://music.fedorapeople.org/20260731/rust-trustfall_rustdoc.spec
New SRPM URL: https://music.fedorapeople.org/20260731/rust-trustfall_rustdoc-0.39.0-1.fc44.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10800118
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2489112-rust-trustfall_rustdoc/fedora-rawhide-x86_64/10800118-rust-trustfall_rustdoc/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks OK after a quick look, except that the LICENSE-MIT file contains a copy of the Apache-2.0 license text, not the MIT license.

(In reply to Fabio Valentini from comment #6)
> Looks OK after a quick look, except that the LICENSE-MIT file contains a
> copy of the Apache-2.0 license text, not the MIT license.

Thanks. I sent a PR upstream for this, https://github.com/obi1kenobi/trustfall-rustdoc/pull/135. I would expect it to be reviewed within a day or to, at which point I’ll patch in the MIT text and update the submission here.

Updated with the (upstream-accepted) license patch, and with the latest release 0.41, now that there’s a cargo-semver-checks release that supports it. I’ll need to update cargo-semver-checks in bug 2489166 to the latest version as well.

https://github.com/obi1kenobi/trustfall-rustdoc/compare/v0.39.0...v0.41.0

New Spec URL: https://music.fedorapeople.org/20260819/rust-trustfall_rustdoc.spec
New SRPM URL: https://music.fedorapeople.org/20260819/rust-trustfall_rustdoc-0.41.0-1.fc44.src.rpm

Created attachment 2154890 [details]
Updated configuration file for rust2rpm

(In reply to Ben Beasley from comment #8)
> Updated with the (upstream-accepted) license patch, and with the latest
> release 0.41, now that there’s a cargo-semver-checks release that supports
> it. I’ll need to update cargo-semver-checks in bug 2489166 to the latest
> version as well.
> 
> https://github.com/obi1kenobi/trustfall-rustdoc/compare/v0.39.0...v0.41.0
> 
> New Spec URL:
> https://music.fedorapeople.org/20260819/rust-trustfall_rustdoc.spec
> New SRPM URL:
> https://music.fedorapeople.org/20260819/rust-trustfall_rustdoc-0.41.0-1.fc44.
> src.rpm

Thanks for the update - these URLs return HTTP 404 errors though.

(In reply to Fabio Valentini from comment #10)
> Thanks for the update - these URLs return HTTP 404 errors though.

Thanks. This turns out to have been a typo in the directory prefix while uploading. The URLs will work now.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10882340
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2489112-rust-trustfall_rustdoc/fedora-rawhide-x86_64/10882340-rust-trustfall_rustdoc/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10882818
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2489112-rust-trustfall_rustdoc/fedora-rawhide-x86_64/10882818-rust-trustfall_rustdoc/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license files are included with %license in %files:
   LICENSE-MIT contained the Apache-2.0 license text,
   this was fixed upstream and is rectified downstream too.
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Thank you for the review!

https://release-monitoring.org/project/392042/

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-trustfall_rustdoc
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

FEDORA-2026-ce70407f97 (rust-trustfall_rustdoc-0.41.0-1.fc46) has been submitted as an update to Fedora 46.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-ce70407f97

FEDORA-2026-ce70407f97 (rust-trustfall_rustdoc-0.41.0-1.fc46) has been pushed to the Fedora 46 stable repository.
If problem still persists, please make note of it in this bug report.