Bug 2489166 - Review Request: rust-cargo-semver-checks - Scan your Rust crate for semver violations
Summary: Review Request: rust-cargo-semver-checks - Scan your Rust crate for semver vi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cargo-semver...
Whiteboard:
Depends On: 2450829 2489102 2489111 2489112
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-06-16 12:40 UTC by Ben Beasley
Modified: 2026-09-21 06:10 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-09-21 06:10:35 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (2.78 KB, text/plain)
2026-06-16 12:40 UTC, Ben Beasley
no flags Details
Updated configuration file for rust2rpm (2.81 KB, text/plain)
2026-08-01 15:19 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2026-06-16 12:40:23 UTC
Created attachment 2145529 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-cargo-semver-checks.spec
SRPM URL: https://music.fedorapeople.org/rust-cargo-semver-checks-0.48.0-1.fc44.src.rpm
Description: Scan your Rust crate for semver violations.
Fedora Account System Username: music

Comment 1 Ben Beasley 2026-06-16 16:06:23 UTC
Updated (same URLs) with a workaround for OOM on i686.

Comment 3 Fedora Review Service 2026-08-01 15:19:16 UTC
There seems to be some problem with the following file.
SRPM URL: https://music.fedorapeople.org/20260831/rust-cargo-semver-checks-0.49.0-1.fc44.src.rpm
Fetching it results in a 403 Forbidden error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Ben Beasley 2026-08-01 15:19:46 UTC
Created attachment 2153219 [details]
Updated configuration file for rust2rpm

Comment 6 Fedora Review Service 2026-08-01 15:25:57 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10802792
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2489166-rust-cargo-semver-checks/fedora-rawhide-x86_64/10802792-rust-cargo-semver-checks/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fedora Review Service 2026-08-20 02:22:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10882641
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2489166-rust-cargo-semver-checks/fedora-rawhide-x86_64/10882641-rust-cargo-semver-checks/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Fabio Valentini 2026-09-18 14:37:57 UTC
Package was generated with rust2rpm, simplifying the review.
I was able to reproduce the provided spec file with the attached rust2rpm.toml config (except for the license list).

Looks like all is in good order. Being able to run tests (with a bit of wrangling) is great.
I'm a bit surprised that c-s-c supports neither generation of shell completions nor a manual page ... but what can you do.

It looks like basically nothing relevant is using cargo-semver-checks as a (Rust) library, so you could consider setting `cargo-install-lib = false` to avoid producing "-devel" subpackages, but I'll leave that up to you.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ licenses of statically linked dependencies are correctly taken into account
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 10 Ben Beasley 2026-09-20 10:20:20 UTC
Thank you for the review!

(In reply to Fabio Valentini from comment #9)
> Package was generated with rust2rpm, simplifying the review.
> I was able to reproduce the provided spec file with the attached
> rust2rpm.toml config (except for the license list).
> 
> Looks like all is in good order. Being able to run tests (with a bit of
> wrangling) is great.
> I'm a bit surprised that c-s-c supports neither generation of shell
> completions nor a manual page ... but what can you do.

I expect they would consider reasonable PRs, but I’m not likely to craft those PRs in the short term.

> It looks like basically nothing relevant is using cargo-semver-checks as a
> (Rust) library, so you could consider setting `cargo-install-lib = false` to
> avoid producing "-devel" subpackages, but I'll leave that up to you.

That’s a good idea. It would allow me to ignore SemVer-API-compatibility for Updates Policy purposes in EPEL and instead only have to worry about CLI compatibility.

https://release-monitoring.org/project/392380/

Comment 11 Fedora Admin user for bugzilla script actions 2026-09-20 10:33:13 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-semver-checks
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 12 Fedora Update System 2026-09-21 06:07:27 UTC
FEDORA-2026-8e65483980 (rust-cargo-semver-checks-0.50.0-3.fc46) has been submitted as an update to Fedora 46.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-8e65483980

Comment 13 Fedora Update System 2026-09-21 06:10:35 UTC
FEDORA-2026-8e65483980 (rust-cargo-semver-checks-0.50.0-3.fc46) has been pushed to the Fedora 46 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.