Bug 2491207

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10622211
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491207-python-pynitrokey/fedora-rawhide-x86_64/10622211-python-pynitrokey/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> BuildRequires: python3dist(pytest)
> BuildRequires: python3dist(oath)
The right column could be indented by one line more to match the rest of the file.

Hmm, should the main package be called 'python3-pynitrokey' or just 'nitropy'?
I guess the existing name is better. But please add 'Provides: nitropy' so that
people can easily install using the executable name.

It'd also be nice to extend the %description for the binary package with
some hints what nitropy is good for. Something that'd tell people what
this package is useful for, and also make it easier if they're trying to
deal with TOTP and such.

> Requires:       /usr/lib/udev/rules.d/41-nitrokey.rules
This is not allowed (and it also doesn't work with dnf5):
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies:
> Packages MAY include such dependencies for paths inside one of the following directories:
> /usr/bin
> /etc

What was the error that rpmlint gave?

Looks reasonable in general.

> The right column could be indented by one line more to match the rest of the file.
Done

> But please add 'Provides: nitropy' so that people can easily install using the executable name.
Done

> It'd also be nice to extend the %description for the binary package with
> some hints what nitropy is good for. Something that'd tell people what
> this package is useful for, and also make it easier if they're trying to
> deal with TOTP and such.
Expanded it a bit

> This is not allowed (and it also doesn't work with dnf5):
Oh interesting. Explains some errors I was having on a non-Fedora project...

> What was the error that rpmlint gave?
python3-pynitrokey.noarch: E: explicit-lib-dependency libnitrokey.
libnitrokey doesn't have a `pkgconfig(` provides or similar that could be used instead.

Spec URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/python3-pynitrokey/srpm-builds/10622651/python-pynitrokey.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/python3-pynitrokey/srpm-builds/10622651/python-pynitrokey-0.12.3-1.src.rpm

Created attachment 2146179 [details]
The .spec file difference from Copr build 10622211 to 10622652

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10622652
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491207-python-pynitrokey/fedora-rawhide-x86_64/10622652-python-pynitrokey/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> python3-pynitrokey.noarch: E: explicit-lib-dependency libnitrokey.
The rpmlint error is meant to prevent manual dependencies being added for
shared libraries, but here the dependency is on the package for other files
that are in it. So please just use 'Requires: libnitrokey'.
(rpmlint is often wrong. Don't take it what is says as gospel.)

+ package name is OK
+ latest version
+ license is specified correctly (MIT + Apache 2.0)
+ license is acceptable for Fedora
+ builds and installs OK
+ R/BR/P appear correct (modulo the issue discussed above).

Standard pyproject packaging is used, nothing out of the ordinary.

The udev rules provided by libnitrokey look reasonable too.

Package is APPROVED. Please fix the libnitrokey dep when importing.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pynitrokey
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

FEDORA-2026-cfc6f24990 (python-pynitrokey-0.12.3-2.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-cfc6f24990

FEDORA-2026-cfc6f24990 (python-pynitrokey-0.12.3-2.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2026-389c1e6a79 (python-pynitrokey-0.12.3-2.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-389c1e6a79

FEDORA-2026-d42f000478 (python-pynitrokey-0.12.3-2.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-d42f000478

FEDORA-2026-389c1e6a79 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-389c1e6a79 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-389c1e6a79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2026-d42f000478 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-d42f000478 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-d42f000478

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2026-389c1e6a79 (python-pynitrokey-0.12.3-2.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2026-d42f000478 (python-pynitrokey-0.12.3-2.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.