Bug 2491198 - Review Request: python-nkdfu - DFU tool for updating Nitrokeys firmware
Summary: Review Request: python-nkdfu - DFU tool for updating Nitrokeys firmware
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/Nitrokey/nkdfu
Whiteboard:
Depends On:
Blocks: 2491207
TreeView+ depends on / blocked
 
Reported: 2026-06-21 16:42 UTC by Daniel Milnes
Modified: 2026-06-21 20:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-06-21 20:28:14 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 2491195 0 unspecified CLOSED Build for Branched Releases 2026-07-07 01:09:46 UTC

Comment 1 Fedora Review Service 2026-06-21 16:45:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10622151
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491198-python-nkdfu/fedora-rawhide-x86_64/10622151-python-nkdfu/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Zbigniew Jędrzejewski-Szmek 2026-06-21 20:02:05 UTC
rpmlint:
python3-nkdfu.noarch: W: no-manual-page-for-binary nkdfu
python3-nkdfu.noarch: E: incorrect-fsf-address /usr/lib/python3.15/site-packages/nkdfu-0.2.dist-info/licenses/LICENSE
python3-nkdfu.noarch: E: incorrect-fsf-address /usr/share/licenses/python3-nkdfu/LICENSE
 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2 badness; has taken 0.2 s 

A man page would be nice, but is not a blocker. The FSF address is
an upstream issue and can ignored. Nobody cares about this.

+ package name is OK
+ latest version
+ license is specified correctly (GPL-2.0)
+ license is acceptable for Fedora
+ builds and installs OK
+ R/BR/P appear correct

Package is APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2026-06-21 20:10:14 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-nkdfu
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 4 Fedora Update System 2026-06-21 20:25:00 UTC
FEDORA-2026-a17b281e89 (python-nkdfu-0.2-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-a17b281e89

Comment 5 Fedora Update System 2026-06-21 20:28:14 UTC
FEDORA-2026-a17b281e89 (python-nkdfu-0.2-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.