Bug 2493965
| Summary: | Review Request: rust-ureq-proto - Ureq support crate | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/ureq-proto | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2026-07-01 10:10:14 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2329382 | ||||||
| Attachments: |
|
||||||
|
Description
Ben Beasley
2026-06-28 08:12:37 UTC
Spec URL: https://music.fedorapeople.org/rust-ureq-proto.spec SRPM URL: https://music.fedorapeople.org/rust-ureq-proto-0.6.0-1.fc44.src.rpm The Cargo.toml says "MIT OR Apache-2.0" but the repository + crate + package only contain LICENSE-MIT.txt. This is handled correctly in `ureq` itself, so I'm not sure what went wrong there. Good catch, thanks! New Spec URL: https://music.fedorapeople.org/20260629/rust-ureq-proto.spec New SRPM URL: https://music.fedorapeople.org/20260629/rust-ureq-proto-0.6.0-1.fc44.src.rpm Created attachment 2147077 [details]
Configuration file for rust2rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/10660904 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493965-rust-ureq-proto/fedora-rawhide-x86_64/10660904-rust-ureq-proto/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good to me now, thanks! I think it's safe to assume that including the Apache-2.0 license text from ureq into ureq-proto should be fine, so I don't think we need to wait with approving this package review bug until the PR is merged upstream. === Package was generated with rust2rpm, simplifying the review. ✅❌❓🫤 ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files: Apache-2.0 license text seems to be missing accidentally from the upstream repo and published crates. The text is included from a "sibling" project (ureq -> ureq-proto) manually for now. A pull request to fix this missing license text was submitted. ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) Thank you for the review! https://release-monitoring.org/project/390965/ The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ureq-proto Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` FEDORA-2026-49c2fcc4f5 (rust-ureq-proto-0.6.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-49c2fcc4f5 FEDORA-2026-49c2fcc4f5 (rust-ureq-proto-0.6.0-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report. |