Bug 2497173
| Summary: | Review Request: libdial - GTK3 library for displaying clocks and dials | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Artur Frenszek-Iwicki <fedora> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mtasaka, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://theknight.co.uk | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2497174 | ||
|
Description
Artur Frenszek-Iwicki
2026-07-05 17:28:54 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/10684198 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497173-libdial/fedora-rawhide-x86_64/10684198-libdial/fedora-review/review.txt Found issues: - libdial : /usr/include/dialsys.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. A couple of notes:
* I don't see why BR: desktop-file-utils is needed here
* Use BuildRequires: pkgconfig(gtk+-3.0) (see configure.ac), optionally BuildRequires: pkgconfig(gthread-2.0) as well (not strictly needed)
* With above, BR: pkgconfig is unneeded.
* %{_includedir}/dialsys.h must be in -devel package
* Please include AUTHORS as %doc .
* Verify the license tag: as far as I checked this, this should be License: GPL-3.0-or-later AND GPL-2.0-only
(please actually check the files in the tarball)
Also, my recognition is that GPL-3.0-or-later and GPL-2.0-only are incompatible.
> Verify the license tag: as far as I checked this, this should be License: GPL-3.0-or-later AND GPL-2.0-only
> (please actually check the files in the tarball)
> Also, my recognition is that GPL-3.0-or-later and GPL-2.0-only are incompatible.
I contacted the author and they told me that the library was relicensed from GPL-2.0-only
to GPL-3.0-or-later at some point and they just missed updating the licensing headers
in some of the files.
The author also said that they're planning to release a new version soon (TM),
so I think I'll pause this review request until that happens.
Updated to v2.7. All suggested changes applied. spec: https://suve.fedorapeople.org/review/libdial-2.7-1/libdial.spec spec: https://suve.fedorapeople.org/review/libdial-2.7-1/libdial-2.7-1.fc44.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=149005534 |