Fedora Account System
Red Hat Associate
Red Hat Customer
spec: https://suve.fedorapeople.org/review/libdial-2.6-1/libdial.spec spec: https://suve.fedorapeople.org/review/libdial-2.6-1/libdial-2.6-1.fc44.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=147440767 Description: libdial is a GTK3 library for displaying clocks and dials. Fedora Account System Username: suve
Copr build: https://copr.fedorainfracloud.org/coprs/build/10684198 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497173-libdial/fedora-rawhide-x86_64/10684198-libdial/fedora-review/review.txt Found issues: - libdial : /usr/include/dialsys.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
A couple of notes: * I don't see why BR: desktop-file-utils is needed here * Use BuildRequires: pkgconfig(gtk+-3.0) (see configure.ac), optionally BuildRequires: pkgconfig(gthread-2.0) as well (not strictly needed) * With above, BR: pkgconfig is unneeded. * %{_includedir}/dialsys.h must be in -devel package * Please include AUTHORS as %doc . * Verify the license tag: as far as I checked this, this should be License: GPL-3.0-or-later AND GPL-2.0-only (please actually check the files in the tarball) Also, my recognition is that GPL-3.0-or-later and GPL-2.0-only are incompatible.
> Verify the license tag: as far as I checked this, this should be License: GPL-3.0-or-later AND GPL-2.0-only > (please actually check the files in the tarball) > Also, my recognition is that GPL-3.0-or-later and GPL-2.0-only are incompatible. I contacted the author and they told me that the library was relicensed from GPL-2.0-only to GPL-3.0-or-later at some point and they just missed updating the licensing headers in some of the files. The author also said that they're planning to release a new version soon (TM), so I think I'll pause this review request until that happens.