Bug 2497352
| Summary: | Review Request: rust-glycin-image-rs - Sandboxed image decoding | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | michel, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/glycin-image-rs | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-08-11 10:50:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2492988 | ||
|
Description
Fabio Valentini
2026-07-06 13:58:48 UTC
A successful build with all dependencies present is available in COPR: https://copr.fedorainfracloud.org/coprs/decathorpe/glycin-next/monitor/ rust2rpm.toml config file: ``` [package] license-files = ["LICENSE-LGPL-2.1", "LICENSE-MPL-2.0"] [[package.extra-sources]] number = 2 file = "https://gitlab.gnome.org/GNOME/glycin/-/raw/2.2.alpha.4/LICENSE-LGPL-2.1" comments = ["https://gitlab.gnome.org/GNOME/glycin/-/work_items/305"] [[package.extra-sources]] number = 3 file = "https://gitlab.gnome.org/GNOME/glycin/-/raw/2.2.alpha.4/LICENSE-MPL-2.0" comments = ["https://gitlab.gnome.org/GNOME/glycin/-/work_items/305"] [scripts] prep.post = ["cp -pav %{SOURCE2} %{SOURCE3} ."] ``` Could you update the licenses for the binary RPM? # FIXME: paste output of %%cargo_license_summary here License: # FIXME # LICENSE.dependencies contains a full license breakdown Thanks for taking a look! Not sure how I missed the FIXME. I dropped the executable for now, since I'm not even sure we need it. If it ends up being needed for something, I can reintroduce it properly later. Updated files behind the same URLs: Spec URL: https://decathorpe.fedorapeople.org/rust-glycin-image-rs.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-glycin-image-rs-2.2.0~alpha-1.fc44.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/10793719 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497352-rust-glycin-image-rs/fedora-rawhide-x86_64/10793719-rust-glycin-image-rs/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. LGTM, please update when importing === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass 🫤 latest version of the crate is packaged (spec: 2.2.0~alpha; crates.io: 2.2.0-beta — update) ✅ license matches upstream specification and is acceptable for Fedora (spec & Cargo.toml: MPL-2.0 OR LGPL-2.1-or-later) 🫤 license file is included with %license in %files (included manually) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: glycin-image-rs homepage: https://crates.io/crates/glycin-image-rs backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-glycin-image-rs - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! I'll update as soon as possible, likely in coordination with the glycin update from GNOME 51.beta. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-glycin-image-rs Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2026-592ddc83fc Update to the latest version will be handled as part of the work for glycin 2.2.beta and loupe 51.beta. |