Bug 249909
Summary: | Need to strip : for mount.cifs support. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 4 | Reporter: | Ray Van Dolson <rvandolson> | ||||||||
Component: | autofs | Assignee: | Jeff Moyer <jmoyer> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Brock Organ <borgan> | ||||||||
Severity: | low | Docs Contact: | |||||||||
Priority: | low | ||||||||||
Version: | 4.5 | CC: | ikent, jlayton, sputhenp | ||||||||
Target Milestone: | rc | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | RHBA-2008-0702 | Doc Type: | Bug Fix | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2008-07-24 19:51:25 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Ray Van Dolson
2007-07-27 20:15:38 UTC
Created attachment 160134 [details]
Strips out un-wanted colon
Created attachment 160135 [details]
Modified spec file to use cifs patch.
spec file I used to include the cifs patch.
I'll take a look at this. Thanks for the patch! Ray, Would you mind including the map entry that you used to test this patch? There are at least 2 ways that a share can be specified, and I want to make sure that the case you use is covered. Jeff, some interesting results. It had been a couple months since I originally filed this so I'd forgotten a bunch of the details. Here are results using an entry in auto.misc: cifs -fstype=cifs,username=rayXXXX,password=XXXXXX,domain=esri.com ://LEORAY-XP/Files This entry appears to work fine via /misc/cifs even with stock version -199.3. Where I run into problems is using an auto.cifs script which generates map entries like this: -fstype=cifs,file_mode=0644,dir_mode=0755,uid=root,gid=root,domain=esri.com,credentials=/etc/auto.cifs.credentials \ /Files ://LEORAY-XP/Files This only works when using my patched version -199.4 which strips the : out. I will attach my auto.cifs file. With -199.3, an strace of mount.cifs's output tells me: execve("/sbin/mount.cifs.real", ["/sbin/mount.cifs.real", "://LEORAY-XP/Files", "/cifs/LEORAY-XP/Files", "-o", "rw,file_mode=0644,dir_mode=0755,uid=0,gid=0,domain=esri.com,credentials=/etc/auto.cifs.credentials"], [/* 24 vars */]) = 0 ... ... write(1, "mount error: could not find target server. TCP name ///LEORAY-XP/Files not found rc = 134526947\nNo ip address specified and hostname not found\n", 144) = 144 I will also note something else interesting and probably unrelated. It does not appear that "mount.cifs" makes use of the "domain" parameter inside a credentials file. However, smbclient does make use of "domain". So I have to provide it on the command line for mount.cifs. Let me know if you need any additional information. Created attachment 204321 [details]
auto.cifs
Word wrapping looks funky above. The maps should all be on one line except the auto.cifs generated one which is line broken where the \ is. This is really helpful information, thank you! I'll see what I can work out. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. A fix for this issue was built into autofs version 4.1.3-131.1. Do you mean 4.1.3-231.1? (In reply to comment #12) > Do you mean 4.1.3-231.1? Yes! Sorry about that! I'm having this exact problem (mount string works with file: but not with program:), but my autofs version is newer than the supposedly patched 4.1.3-231.1. [root@home etc]# rpm -q autofs autofs-5.0.1-31.x86_64 [root@home etc]# uname -a Linux home.cs.siue.edu 2.6.23.8-34.fc7 #1 SMP Thu Nov 22 20:39:56 EST 2007 x86_64 x86_64 x86_64 GNU/Linux [root@home etc]# tail -n 1 /var/log/messages Jan 23 18:44:39 home automount[7567]: parse_mount: parse(sun): failed to expand map entry [root@home etc]# cat /etc/auto.homes #! /bin/bash echo "-fstype=cifs,dom=campus.siue.edu,credentials=/home/gbartho/credentials.txt ://ebserver-11.ac.siue.edu/2\$" exit 0 [root@home etc]# date Wed Jan 23 18:51:27 CST 2008 [root@home etc]# (In reply to comment #14) > I'm having this exact problem (mount string works with file: but not with > program:), but my autofs version is newer than the supposedly patched 4.1.3-231.1. > > [root@home etc]# rpm -q autofs > autofs-5.0.1-31.x86_64 Are you running RHEL 4? It certainly doesn't appear so. You'll want to create a new bug and file it against whichever distribution you are running (FC7?). Sorry, I thought hats and fedoras were made by the same people. I'll try to find fedora's bugzilla. (In reply to comment #16) > Sorry, I thought hats and fedoras were made by the same people. I'll try to find > fedora's bugzilla. Oh, it's the same bugzilla, just a different "Product" tag. So, you can still go to http://bugzilla.redhat.com/, but instead of selecting "Red Hat Enterprise Linux" on the "Enter a new bug" page, you would select Fedora. Here, try this link out: http://tinyurl.com/23tbw6 Just fill in the summary and problem description and click submit. Cheers, Jeff (In reply to comment #16) > Sorry, I thought hats and fedoras were made by the same people. I'll try to find > fedora's bugzilla. I went ahead and filed that bug for you: bug #430113. Cheers, Jeff Verified by RHTS job #23575 I updated the test case to cover more cifs URLs and it fails. The problem is that we overwrite the colon used to denote the server port with a slash. This needs fixing. The test case fails due to not escaping a colon as part of the CIFS url. This is not a bug introduced by this patch set, and should be worked-around using the no-slashify-colons map option. I'm setting this back to modified. Verified RHTS job #24346 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0702.html |