Bug 2501791
| Summary: | Review Request: perl-HTML-Query - JQuery-like selection queries for HTML::Element | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Emmanuel Seyman <emmanuel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | emmanuel, package-review |
| Target Milestone: | --- | Flags: | emmanuel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-10-02 18:16:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2501790 | ||
| Bug Blocks: | 2501793 | ||
|
Description
Xavier Bachelot
2026-07-17 16:37:32 UTC
Taking URL and Source0 are ok
Source0 archive (SHA-512:d173bc70188c84615f909181c645c336256bd6c8afa8dbacd56c21c3d3f34fa15ab5afdbd01a24647c14c0fc2b55d8bb97124464df217d7becec825200589676) is original. Ok.
License verified from HTML/Query.pm is ok.
Summary is ok.
Description is ok
BuildRequires are ok
FIX: Add build-require 'coreutils' - it is needed for %{_fixperms}
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
NO_PACKLIST is provided since this version.
This package fails to build in rawhide.
https://koji.fedoraproject.org/koji/taskinfo?taskID=150675586
It looks like "perl(FindBin)" needs to be added to the BuildRequires (maybe to the Requires of perl-Badger?).
Thanks Emmanuel ! I've added the missing Require: to perl-Badger and rebuilt it in Rawhide. I've also addressed the 2 fixes. The package should now build fine once the fixed perl-Badger is in the repo. Spec URL: https://www.bachelot.org/fedora/SPECS/perl-HTML-Query.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-HTML-Query-0.09-2.fc46.src.rpm URL and Source0 are ok
Source0 archive (SHA-512:7091e503b11c9d1c5a3dd38156467cf398ae4b96e1c109db4781478dfb100c2cc50e688c742392f66b9f195b936c19cafe003fffe4fc0459165b02622c154f72) is original. Ok.
License verified from Encoding/FixLatin.pm is ok.
Summary is ok.
Description is ok
BuildRequires are ok
$ rpm -qp --requires perl-Encoding-FixLatin* | sort | uniq -c | grep -v rpmlib
1 perl(Carp)
1 perl(Encode)
1 perl(Encoding::FixLatin)
1 perl(Exporter)
1 perl(Getopt::Long)
1 perl-libs
1 perl(Pod::Usage)
1 perl(strict)
1 perl(:VERSION) >= 5.8.0
1 perl(warnings)
1 /usr/bin/perl
Binary requires are Ok.
$ rpm -qp --provides perl-Encoding-FixLatin* | sort | uniq -c
Binary provides are Ok.
$ rpmlint output: 0 errors, 0 warnings, 4 filtered, 0 badness
The package is in line with Fedora and Perl packaging guide lines.
Resolution:
Approved
> $ rpmlint output: 0 errors, 0 warnings, 4 filtered, 0 badness
Sorry, that should be: 4 errors, 0 warnings, 6 filtered, 4 badness
You'll probably want to add a .rpmlintrc in the repo once the package has been imported.
Hi Emmanuel, Comment 4 is referring to Encoding::FixLatin. Could you please take another look ? Regards, Xavier Copy/pasting the wrong file gives you the wrong content. Who could have guessed? URL and Source0 are ok Source0 archive (SHA-512:d173bc70188c84615f909181c645c336256bd6c8afa8dbacd56c21c3d3f34fa15ab5afdbd01a24647c14c0fc2b55d8bb97124464df217d7becec825200589676) is original. Ok. License verified from HTML/Query.pm is ok. Summary is ok. Description is ok BuildRequires are ok Source package builds in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=150798844 $ rpm -qp --requires perl-HTML-Query* | sort | uniq -c | grep -v rpmlib 1 coreutils 1 make 1 perl(Badger) >= 0.03 2 perl(Badger::Class) 1 perl(Badger::Filesystem) 1 perl(Badger::Test) 1 perl(ExtUtils::MakeMaker) >= 6.76 1 perl-generators 2 perl(HTML::Tree) >= 3.23 1 perl(HTML::TreeBuilder) 1 perl-interpreter 1 perl(lib) 1 perl-libs 1 perl(strict) 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-HTML-Query* | sort | uniq -c 1 perl(HTML::Query) = 0.09 2 perl-HTML-Query = 0.09-2.fc46 Binary provides are Ok. $ rpmlint output: 4 errors, 0 warnings, 6 filtered, 4 badness The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTML-Query Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` FEDORA-2026-95ce5ab7ec (perl-HTML-Query-0.09-2.fc46) has been submitted as an update to Fedora 46. https://bodhi.fedoraproject.org/updates/FEDORA-2026-95ce5ab7ec FEDORA-2026-95ce5ab7ec (perl-HTML-Query-0.09-2.fc46) has been pushed to the Fedora 46 stable repository. If problem still persists, please make note of it in this bug report. |