Bug 2501793 - Review Request: perl-CSS-Inliner - perl-CSS-Inliner
Summary: Review Request: perl-CSS-Inliner - perl-CSS-Inliner
Keywords:
Status: RELEASE_PENDING
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2501791 2501792
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-07-17 16:41 UTC by Xavier Bachelot
Modified: 2026-10-06 09:07 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
emmanuel: fedora-review+


Attachments (Terms of Use)

Description Xavier Bachelot 2026-07-17 16:41:25 UTC
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-CSS-Inliner.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-CSS-Inliner-4027-1.fc45.src.rpm
Description:
Library for converting CSS style blocks into inline styles in an HTML
document. Specifically this is intended for the ease of generating HTML
emails. This is useful as certain email clients don't support top level
<style> declarations despite it being 2017.


Fedora Account System Username: xavierb

Comment 1 Xavier Bachelot 2026-07-17 16:56:24 UTC
This is one of the new dependency needed for rt 5.0.10

Comment 2 Emmanuel Seyman 2026-10-05 23:39:16 UTC
Taking.

Comment 3 Emmanuel Seyman 2026-10-06 00:04:16 UTC
URL and Source0 are ok
Source0 archive (SHA-512:0ded8239b4368d8aa1139c10f21db824b7aef4294bcd7e97a66e3f697ce96fe9fb8a048956401251507eab097f41cd2884d8953a36bd9bfe2e29b7ccbd35681a) is original. Ok.
License verified from lib/CSS/Inliner.pm is ok.
Summary is ok.
Description is ok

BuildRequires are ok
FIX: Include coreutils in the BR (%{_fixperms} calls chmod)
FIX: Specify version >= 6.76 for "perl(ExtUtils::MakeMaker)" (you need this to pass NO_PACKLIST=1 to Makefile.PL)

$ rpm -qp --requires perl-CSS-Inliner*.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(CSS::Inliner::Parser)
      1 perl(CSS::Inliner::TreeBuilder)
      1 perl(Encode)
      1 perl(HTML::Entities)
      1 perl(HTML::Query)
      1 perl(HTML::TreeBuilder)
      1 perl-libs
      1 perl(LWP::UserAgent)
      1 perl(Storable)
      1 perl(strict)
      1 perl(URI)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-CSS-Inliner*.noarch.rpm | sort | uniq -c
      1 perl(CSS::Inliner) = 4027
      1 perl-CSS-Inliner = 4027-1.fc46
      1 perl(CSS::Inliner::Parser)
      1 perl(CSS::Inliner::TreeBuilder)
Binary provides are Ok.

$ rpmlint *

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' item and consider fixing 'TODO' items.

Resolution:
Approved

Comment 4 Fedora Admin user for bugzilla script actions 2026-10-06 09:07:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-CSS-Inliner
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`


Note You need to log in before you can comment on or make changes to this bug.