Bug 2513913
| Summary: | Review Request: bash-color-prompt - Bash Color Prompt with customization | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | Mike FABIAN <mfabian> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | benson_muite, mfabian, package-review |
| Target Milestone: | --- | Flags: | mfabian:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/juhp/bash-color-prompt | ||
| Whiteboard: | |||
| Fixed In Version: | bash-color-prompt-0.96.2-1.fc46 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-09-09 06:58:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2503680 | ||
|
Description
Jens Petersen
2026-08-11 11:49:09 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/10845986 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2513913-bash-color-prompt/fedora-rawhide-x86_64/10845986-bash-color-prompt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This is part of https://fedoraproject.org/wiki/Changes/BashColorPrompt_1.0 There is also a copr repo for Fedora and EPEL 10 releases: https://copr.fedorainfracloud.org/coprs/petersen/bash-color-prompt/ Also this is mostly just a rename of the shell-color-prompt source package. Though it does contain a major version bump for the Change. As such the package review itself should be pretty straightforward, since the binary package name is unchanged. I can also emphasize here that the default prompt remains pixel identical to the current version. Sorry Benson, I asked Mike to help with the review because of the urgency as I will be away next week and the freeze starts on Tue. It looks OK to me and I tested it a bit and found no issues. the spec file looks fine to me. Thank you for the review, Mike The Pagure repository was created at https://src.fedoraproject.org/rpms/bash-color-prompt Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` I missed to declare here AI usage on this code base (I wasn't fully aware of this requirement at the time when I submitted this package or until after it was approved). The initial code was generated by Gemini Pro earlier this year in chat conversations which I reviewed carefully and improved upon. The recent change to the improved Builder Pattern approach was also AI assisted. I am reasonably confident that the code is of a decent quality, though suggestions for further improvement are welcome. |