Bug 251400
Summary: | make find-lang.sh --with-gnome pick up omf files | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> | ||||
Component: | rpm | Assignee: | Panu Matilainen <pmatilai> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | low | ||||||
Version: | rawhide | ||||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-08-15 09:51:01 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Matthias Clasen
2007-08-08 18:44:38 UTC
Created attachment 160927 [details]
patch
Jeremy also proposes to make --with-gnome --with-kde the default in our %find_lang macro. I suppose it'd be good to have --with-omf to be in line with the other cases but... I wonder what has been the real point of all the --with-gnome etc options in the first place. The point is to get %lang tagging for all the big locale-dependent files, so that _install_langs can do its magic. The documentation under gnome/help is the reason why evolution is the second-largest package on the live cd... Yes, I can see that :) I'm just wondering why those --gnome etc things have bee optional to begin with if they dont break anything. To make it clear, I'm not opposed to this or anything, just curious. Good question. The only slight concern is that turning it on by default now will cause duplication between foo.lang and the explicit file list, with one entry having a %lang tag, the other not. But I assume that rpm will handle that correctly. Hey, this is rpm - assumptions are inherently dangerous :) I don't actually know what will happen in such a case, but the worst that can happen is that duplicates (which you'll get warned about) dont get treated as lang-files. Which is harmless as it's no worse than what was before. As for the patch itself, upstream at rpm.org and building right now into rawhide, will be in rpm-4.4.2.1-8.fc8. I've been totally blind and missed the fact that the .omf files were only searched when --with-gnome was specified, that's safe enough for me. Thanks for the patch :) Turning --with-kde and --with-gnome on by default in redhat-rpm-config is out of my control, but I'm in no way opposed to that. |